search

cornell-zhang / heterocl

HeteroCL: A Multi-Paradigm Programming Infrastructure for Software-Defined Heterogeneous Computing
https://cornell-zhang.github.io/heterocl/
Apache License 2.0
326 stars 92 forks source link

[API] HLS Report Enhancement - Bug Fix #376

Closed yn224 closed 3 years ago

yn224 commented 3 years ago

This PR attempts to fix a bug that was found in PR #337. Specifically, it attempts to resolve an issue where the algorithm fails to capture all the loops when multiple loops are in the same loop nest level inside one main loop in a form like such:

A : {
  A_x : {}
  A_y : {}
  A_z : {}
}
seanlatias commented 3 years ago

@yn224 please do the following

  1. Merge with the latest upstream repo
  2. Add test cases for your new features
seanlatias commented 3 years ago

@yn224 please try #378

seanlatias commented 3 years ago

@yn224 can you merge master branch? Instead of copying the changes. We want to minimize the number of files changed.

yn224 commented 3 years ago

@seanlatias I do not see any commit history difference between the master and this branch except for the files I had to modify?

seanlatias commented 3 years ago

Not sure what you mean "commit history difference". What I meant is to merge the master branch explicitly, instead of copying the changes by yourself.

yn224 commented 3 years ago

Should I delete the changes I made manually and merge master then?

yn224 commented 3 years ago

@seanlatias Any further comments?

yn224 commented 3 years ago

@seanlatias I think the design is now finalized with new tests.