[Backend] Fixes to host code generator and HCL runtime

cornell-zhang / heterocl

HeteroCL: A Multi-Paradigm Programming Infrastructure for Software-Defined Heterogeneous Computing

https://cornell-zhang.github.io/heterocl/

Apache License 2.0

322 stars 92 forks source link

[Backend] Fixes to host code generator and HCL runtime #394

Closed hecmay closed 3 years ago

hecmay commented 3 years ago

[x] Fixed #391 (host code generator prints empty names for input arguments)

seanlatias commented 3 years ago

Can you remove unrelated file changes?

hecmay commented 3 years ago

Can you remove unrelated file changes?

Done.

seanlatias commented 3 years ago

Please add a test that echos the issue.

seanlatias commented 3 years ago

Also, I think it's fine you keep the changes for the platform importing issue.

hecmay commented 3 years ago

Please add a test that echos the issue.

Okay.

BTW, can I also include changes that are needed enable to local CI/CD in this PR? otherwise the test case would not pass on Circle CI, since it requires running through vitis.

hecmay commented 3 years ago

The HCL in master branch is still using inter-process shared memory to communicate with host program. I may also nee to change that to JSON.

seanlatias commented 3 years ago

For shared memory, we create a separate PR. For CI settings, you can check how we test for vivado right now. We just need to add an option for pytest. We don't need the hcl-develop tag.

yn224 commented 3 years ago

Can this PR be merged?

hecmay commented 3 years ago

@yn224 I will add some more test cases for the fix and request a review later. Hopefully it can be merged soon.