search

cornell-zhang / heterocl

HeteroCL: A Multi-Paradigm Programming Infrastructure for Software-Defined Heterogeneous Computing
https://cornell-zhang.github.io/heterocl/
Apache License 2.0
322 stars 92 forks source link

[AST] Add operators to simplify and test cases for them #491

Closed rlin569 closed 1 year ago

rlin569 commented 1 year ago

Added operations to simplify(expr) in ast.py. Added basic test cases to test_simplify.py.

zzzDavid commented 1 year ago

Hi Raymond,

Thanks for the PR! I see that CI pylint is issuing this warning "R0022: Useless option value for disable: 'no-self-use' was moved to an optional extension".

no-self-use refers to the situation where a class method does not use the self argument This was a warning in the previous version of pylint, but later on, pylint people decided it’s not necessary to raise a warning for such situation, so they move it to optional warning This means we don’t have to disable no-self-use anymore, it’s already disabled in the new pylint version To fix this:

  1. Update your local pylint to latest version
  2. Delete all no-self-use, try running pylint again, there should be no more warnings