search

cornell-zhang / heterocl

HeteroCL: A Multi-Paradigm Programming Infrastructure for Software-Defined Heterogeneous Computing
https://cornell-zhang.github.io/heterocl/
Apache License 2.0
322 stars 92 forks source link

[Refactor] Fix Makefile incorrect semantics #86

Closed seanlatias closed 5 years ago

seanlatias commented 5 years ago
  1. If no cmake exists, write to /dev/null
  2. Use Python for floating point comparison
  3. Update LLVM repo with https
Blaok commented 5 years ago

Floating point comparison doesn't work for cmake version 3.10+. I suggest something like ifeq (True, $(shell python -c "print(tuple(map(int,'$(CMAKE_CONFIG)'.split('.')))>(3,4))"))

seanlatias commented 5 years ago

@Blaok Please help check the current Makefile hierarchy and see if you have any suggestions. Thanks.

seanlatias commented 5 years ago

Thanks, @Blaok.