finished DatePicker and TimePicker

cornellh4i / ithaca-recovery

Ithaca Community Recovery Event and Meeting Setup Automation Tool

https://ithaca-recovery.vercel.app

8 stars 3 forks source link

Closed leaneying closed 1 week ago

leaneying commented 4 weeks ago

Implemented a Date Picker and Time Picker component that allows users to select a date/time.

Navigate to http://localhost:3000/test
Scroll to the bottom of the page, and observe the "DatePicker and TimePicker" section created
select the date/time by clicking on the icon to the right

Label is the text next to the picker and can either be a string or JSX.Element (both examples are showcased in the test page)
if you receive an error, the message is displayed in console.log
the last prop is in case we want any additional props to be parsed in beyond the core props

related to issue #36

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ithaca-recovery	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 19, 2024 2:32pm

tunile943 commented 2 weeks ago

Hi folks,

Great job with this ticket. I do have some updates and requests for this PR.

Changes:

Install MUI Icon dependencies
Employ MUI Icon in test page (replace SVG, so Icon can be employed more easily and consistently)
Update styling in TimePicker

Request:

Please update styling for DatePicker according to Figma design. The biggest change required would be related to margin, padding, text font, and text style. I have updated the styling for TimePicker for reference.

That's all for today. I will get back to you soon with your other PR!

leaneying commented 2 weeks ago

finished the revisions (styling adjustments)