cornellh4i / ithaca-recovery

Ithaca Community Recovery Event and Meeting Setup Automation Tool
https://ithaca-recovery.vercel.app
8 stars 3 forks source link

New Meeting Sidebar (Continue) + Date/Time Picker Update #60

Open tunile943 opened 1 week ago

tunile943 commented 1 week ago

Branches: organisms/NewMeeting-frontend + atoms/date-time-picker-fix

Task at Hand

organisms/NewMeeting-frontend (continue):

  1. View the High Fidelity for the New Meeting Sidebar.

  2. Place appropriate atoms in the layout per hi-fi design. You should include the following (others are being implemented):

  1. Confirm that your code and pull request follow the Pull Request Checklist.

    Acceptance Criteria

    • [ ] The sidebar layout have appropriate padding, margins, spacing per hi-fi.

atoms/date-time-picker-fix

  1. Review the High Fidelity for the Num Date Input. Reference:

Image

  1. Add to date/time picker props the following:
    onChange: (value: string) => void;
    underlineOnFocus?: boolean;

So that means that your DatePickerProps should look like this:

interface DatePickerProps {
  label: string | JSX.Element;
  value?: string;
  onChange: (value: string) => void;
  underlineOnFocus?: boolean;
  error?: string;
  [key: string]: any;
}

similarly for TimePickerProps:

interface TimePickerProps {
  label: string | JSX.Element;
  value?: string;
  onChange: (value: string) => void;
  underlineOnFocus?: boolean;
  error?: string;
  disablePast?: boolean;
  [key: string]: any;
}

We want you to implement the following things in atoms/DatePicker and atoms/TimePicker:

  1. Confirm that your code and pull request follow the Pull Request Checklist.

    Acceptance Criteria

    • [ ] Confirm that underline and input format works per Design System (and as described above).

Notes