cornellh4i / lagos-volunteers

Lagos Food Bank Volunteer Management System
https://lagos-volunteers.vercel.app
MIT License
13 stars 6 forks source link

Implement signup cap in ManageAttendees and ViewEventDetails #265

Closed jasozh closed 2 months ago

jasozh commented 4 months ago

Summary

Show the volunteer signup cap properly and prevent volunteers from signing up when exceeding the limit. Also implement WebSockets so that the number of registered volunteers automatically refreshes when the user cancels their registration or is canceled by the supervisor. Finally, volunteers can no longer cancel if the supervisor moves them away from PENDING.

Closes:

Testing

image image

Notes

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lagos-volunteers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2024 9:57pm
akinfelami commented 4 months ago

This is good. The websockets are also clutch. However, I think we need to add server side to complete it.

jasozh commented 4 months ago

Moved client-side filtering to the backend and created 2 new API endpoints. This means we can get rid of calling the entire attendees object.

jasozh commented 4 months ago

This is good. The websockets are also clutch. However, I think we need to add server side to complete it.

What do we need to implement on the server-side? Tested it in two windows and it seems to work as is.

akinfelami commented 4 months ago

This is good. The websockets are also clutch. However, I think we need to add server side to complete it.

What do we need to implement on the server-side? Tested it in two windows and it seems to work as is.

Basically, validations like you can't sign up because the event is full. The server should throw an error if that's the case

jasozh commented 2 months ago

Added server-side validation. Merging the PR as is but lemme know if you have any other concerns.