cornellius-gp / linear_operator

A LinearOperator implementation to wrap the numerical nuts and bolts of GPyTorch
MIT License
95 stars 28 forks source link

`LinearOperatorTestCase`'s `_test_triangular_linear_op_inv_quad_logdet` is skipped and fails otherwise #11

Open SebastianAment opened 2 years ago

SebastianAment commented 2 years ago

LinearOperatorTestCase's _test_triangular_linear_op_inv_quad_logdet is not executed in the current test suite because of the leading underscore. When this underscore is removed, the test executes but fails.

In particular, the test calls _test_inv_quad_logdet and checks if this uses a call to cholesky. However, derived test classes like TestLowRankRootAddedDiagLinearOperator, TestLowRankRootAddedDiagLinearOperatorBatch and TestSumKroneckerLinearOperator apparently don't use Cholesky-based inference for this step (see here for the low rank test), which makes the test fail.