Add level 4 (and clean some .env: calls and white spaces)

cornernote / minetest-skyblock

Build a world starting from a small island in the sky.

https://cornernote.github.io/minetest-skyblock/

Other

11 stars 14 forks source link

Add level 4 (and clean some .env: calls and white spaces) #73

Open Lymkwi opened 8 years ago

Lymkwi commented 8 years ago

Two major issues come to my mind though :

The last quest (craft_ethanol) requires TenPlus1's farming_redo and will not work with vanilla's farming
There is no code (I think) removing fly and fast to people already on level 4. All players could be equal by still granting them on level 4, but we kept it as a reward for finishing the game.

cornernote commented 8 years ago

Hey @LeMagnesium,

Awesome! Thank you!

Are you able to add farming_redo to the depends file?

Lymkwi commented 8 years ago

Are you able to add farming_redo to the depends file?

I think farming is already listed as a dependencie, but there is no way to determine that you are using farming redo instead of vanilla's version before loading the mod... I could add an assertion, or a condition at the beginning of init.lua to block the mod from being loaded if there is no item registered with the name farming:corn.

Panquesito7 commented 3 years ago

@cornernote, may I re-make this PR? It's a good idea to implement this (also the #58 PR). Thanks. 🙂

cornernote commented 3 years ago

hey @Lymkwi , I can't auto merge this because it's got conflicts. If you re-make it I'll merge it in.

Panquesito7 commented 3 years ago

hey @Lymkwi , I can't auto merge this because it's got conflicts. If you re-make it I'll merge it in.

Also, see https://github.com/cornernote/minetest-skyblock/pull/58#issuecomment-862908233.