Closed md-prog closed 1 year ago
Merging #1537 (0ada1b7) into master (925a3dd) will increase coverage by
1.22%
. The diff coverage is58.82%
.:exclamation: Current head 0ada1b7 differs from pull request most recent head d675825. Consider uploading reports for the commit d675825 to get more accurate results
@@ Coverage Diff @@
## master #1537 +/- ##
==========================================
+ Coverage 21.70% 22.92% +1.22%
==========================================
Files 287 288 +1
Lines 10137 10070 -67
Branches 2081 2053 -28
==========================================
+ Hits 2200 2309 +109
+ Misses 6750 6611 -139
+ Partials 1187 1150 -37
Impacted Files | Coverage Δ | |
---|---|---|
src/tools/annotation/_utils.js | 48.14% <48.14%> (ø) |
|
src/tools/annotation/CircleRoiTool.js | 88.79% <100.00%> (+10.94%) |
:arrow_up: |
src/tools/annotation/EllipticalRoiTool.js | 75.92% <100.00%> (+42.59%) |
:arrow_up: |
src/tools/annotation/RectangleRoiTool.js | 84.00% <100.00%> (+40.60%) |
:arrow_up: |
... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:tada: This PR is included in version 6.0.9 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug Fix: _createTextBoxContent() function call during rendering sometimes causes undefined error.
Ideal flow would have been, first calculate all values of
cachedStats
and then call the_createTextBoxContent()
function. But in reality, particularly for the initial load, the_createTextBoxContent()
function is called before thecachedStats
values are calculated.Gave default value: 0, for the
cachedStats
values that are being used by_createTextBoxContent()
. This will preventundefined
error until they are correctly caculcated.No