Closed ViniciusResende closed 1 year ago
Merging #1549 (afa277c) into master (73cd522) will increase coverage by
0.55%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 23.30% 23.86% +0.55%
==========================================
Files 287 287
Lines 10138 10141 +3
Branches 2082 2082
==========================================
+ Hits 2363 2420 +57
+ Misses 6625 6575 -50
+ Partials 1150 1146 -4
Impacted Files | Coverage Δ | |
---|---|---|
...eventListeners/internals/renderSegmentationFill.js | 90.32% <100.00%> (+88.68%) |
:arrow_up: |
...ntListeners/internals/renderSegmentationOutline.js | 81.18% <100.00%> (+0.18%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
LGTM 🏅
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This PR contains a bug fix.
What is the current behavior? (You can also link to an open issue here) The current behavior is that my overlay (rendered using the
Overlay Tool
) is getting resized and translated once the segmentation is rendered.Note that the text is not even entirely on the screen, also there are two ellipsis that aren't even being shown, they appear on the screenshot below.
Now we can see that the text is well positioned and that the ellipsis are in the right place.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) This PR shoudn't introduce any breaking change.
Other information: Previously after rendering the segmentation cornerstone was always transforming the canvas to follow the identity matrix, but in cases where we had an overlay using a different transformation matrix, it would undesirably affect the original overlay. Also did some minor refactorings on the
renderFill
function of thesrc/eventListeners/internals/renderSegmentationFill.js
file.