cornerstonejs / cornerstoneTools

A framework for tools built on top of Cornerstone.
https://tools.cornerstonejs.org/
MIT License
577 stars 452 forks source link

fix(AngleTool): fixed bug that was preventing text box to handle for 0 deg angle #1570

Open ViniciusResende opened 2 months ago

ViniciusResende commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.45%. Comparing base (dbf874f) to head (8365fd1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1570 +/- ## ========================================== + Coverage 23.86% 24.45% +0.59% ========================================== Files 287 287 Lines 10141 10145 +4 Branches 2082 2085 +3 ========================================== + Hits 2420 2481 +61 + Misses 6575 6529 -46 + Partials 1146 1135 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

igoroctaviano commented 2 months ago

@ViniciusResende could you replicate this issue using ohif v2 and cstools?

ViniciusResende commented 2 months ago

@igoroctaviano yes, I could replicate both the error and the fix on OHIF v2. Although is not easy to replicate it, since the angle have to be exactly 0.