cornerstonejs / cornerstoneWADOImageLoader

[DEPRECATED] DICOM WADO Image Loader for the cornerstone library
MIT License
280 stars 267 forks source link

feat: adding support for multiframe metadata in wadors and wadouri #494

Closed rodrigobasilio2022 closed 1 year ago

rodrigobasilio2022 commented 1 year ago

This pull request enables the wado loader to work with multi-frame images. It changes the metadataManager.js and expects imageids with frames/1, frames/2, indicating the frame needed. The function to convert a list of multiframe imageids to a list of imageids with frame number can be found in the /utils/demo/helpers/convertMultiframeImageIds.js in a PR of cornerstone-beta

netlify[bot] commented 1 year ago

Deploy Preview for cornerstone-wado-image-loader ready!

Name Link
Latest commit a0e62a92f486dafc6153caf1d5c5d97e7e70c4a5
Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/63c5acbaf4ace8000812ce33
Deploy Preview https://deploy-preview-494--cornerstone-wado-image-loader.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

wayfarer3130 commented 1 year ago

Generally looks ok - a couple of smaller comments, but mostly looks like it should work. As datasets get bigger, it may be useful optimizing the combine so that it does a lazy combine as required, or perhaps caches the result.

sedghi commented 1 year ago

:tada: This PR is included in version 4.8.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: