cornerstonejs / cornerstoneWADOImageLoader

[DEPRECATED] DICOM WADO Image Loader for the cornerstone library
MIT License
284 stars 266 forks source link

fix: blurry pixels bug for decoding of jpeg2000 #497

Closed sedghi closed 1 year ago

sedghi commented 1 year ago

Switching j2k decoder to wasm had introduced a pixelated/blury bug for some images.

Reported here:

Data by community can be found here

Steps taken discussed here

CC @swederik @heyflynn @kunjesh1 @lambacini , try here https://deploy-preview-497--cornerstone-wado-image-loader.netlify.app/dicomfile/index.html

Also Chris @chafey just fixed the decode problem here which I will use in codecs

netlify[bot] commented 1 year ago

Deploy Preview for cornerstone-wado-image-loader ready!

Name Link
Latest commit cf3c1202d1c565ed9a708621789485bd857f1843
Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/638ff43e7362110008c8b8de
Deploy Preview https://deploy-preview-497--cornerstone-wado-image-loader.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

lambacini commented 1 year ago

CR Image image CT Image ct_test

i tested it with previous test images. everything seems fine, thanks.

kunjesh1 commented 1 year ago

Thanks @sedghi , its working now :) Screenshot 2022-12-09 at 11 52 30 AM

daniel-encord commented 1 year ago

Hey @swederik and @sedghi, is there an estimated time on when this fix will go in? Thanks

sedghi commented 1 year ago

@daniel-encord We have updated the codecs that should solve it at codecs level. I don't want to merge this PR, but update codecs versions. I need time to do some final tests

daniel-encord commented 1 year ago

Thanks for the swift response @sedghi ! 🙏 will keep an eye out for the fix 🙌

sedghi commented 1 year ago

Fixed