search

cornerstonejs / cornerstoneWADOImageLoader

[Deprecated] Use Cornerstone3D Instead https://cornerstonejs.org/
MIT License
285 stars 264 forks source link

fix(bundle): include codecs chunks into bundle in bundle mode #517

Closed NikGurev closed 1 year ago

NikGurev commented 1 year ago

previously webpack:bundle script created 610.bundle.min.js and 888.bundle.min.js files that caused incorrect referencing in other applications (examples: [ #511 , #479 , #439 ]).

Updated webpack config to include all chunks together. Actually, this approanch helped with incorrect referencing in embedded OHIF Viewer that we're using in our app

Previous dist build: image

Current dist build: MoMAAZXepB

netlify[bot] commented 1 year ago

Deploy Preview for cornerstone-wado-image-loader ready!

Name Link
Latest commit 688661a89e15156b2e24dd7ddd7640c71d2c30ff
Latest deploy log https://app.netlify.com/sites/cornerstone-wado-image-loader/deploys/64146947d8209800089eb51b
Deploy Preview https://deploy-preview-517--cornerstone-wado-image-loader.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

NikGurev commented 1 year ago

@sedghi @swederik could you please review and give a feedback? Thank you in advance

swederik commented 1 year ago

Thanks! I think this is fine. Looks like an oversight on our part. Multiple chunks is okay for the dynamic import version but indeed we should only have one for the bundled UMD version of the library. I'll leave it to @sedghi to merge.

sedghi commented 1 year ago

I will merge this, but interested to know why you are not using dynamic import one which is smaller and faster?

sedghi commented 1 year ago

:tada: This PR is included in version 4.10.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: