search

cornerstonejs / cornerstoneWebImageLoader

Cornerstone Image Loader for Web Images (PNG, JPEG)
MIT License
69 stars 50 forks source link

Package import issue #17

Closed dannyrb closed 7 years ago

dannyrb commented 7 years ago

Missing main tag in package.json requires a more explicit path to use. You can see expected usage versus actual usage below. Here is an example of the tag in cornerstoneWADOImageLoader:

https://github.com/chafey/cornerstoneWADOImageLoader/blob/master/package.json#L15

Expected:

Global <script src="https://unpkg.com/cornerstone-web-image-loader"></script>

Import import * as cornerstoneWebImageLoader from 'cornerstone-web-image-loader

Actual:

Global <script src="https://unpkg.com/cornerstone-web-image-loader@0.8.2/dist/cornerstoneWebImageLoader.js"></script>

Import import * as cornerstoneWebImageLoader from 'cornerstone-web-image-loader/dist/cornerstoneWebImageLoader.js

If I get a :+1:, I'll make a quick PR

dannyrb commented 7 years ago

I lied @swederik, I made a PR without your 👍 Simple single liner.

dannyrb commented 7 years ago

@swederik is there a way to trigger an automatic NPM package release?

swederik commented 7 years ago

Not that I'm aware of :-( What's your npm username? I just published 0.8.3

dannyrb commented 7 years ago

Thanks for publishing a release :+1: You can find me on NPM here: https://www.npmjs.com/~dannyrb

If you find yourself spending a lot of time manually publishing releases, we can have a conversation around Continuous Integration / release / deployment?

Closing, because that publish fixed my issue 🎉 You can see for yourself by visiting: https://unpkg.com/cornerstone-web-image-loader