Migrate from $.Deferred to Promises

cornerstonejs / cornerstoneWebImageLoader

Cornerstone Image Loader for Web Images (PNG, JPEG)

MIT License

69 stars 50 forks source link

Migrate from $.Deferred to Promises #20

Closed swederik closed 6 years ago

swederik commented 6 years ago

Changes:

Remove jQuery from external modules
Switch getPixelData to just return the canvas imageData.data. The previous loop to set alpha channel to 255 is unnecessary since we can now just set image.rgba = false.
Set image.rgba to false by default. Users can change this to have the image rendered with the alpha channel intact.
Switch event triggering to use cornerstone.triggerEvent with only the lower case event name: 'cornerstoneimageloadprogress'

coveralls commented 6 years ago

Coverage decreased (-1.6%) to 4.054% when pulling f622a4559ef68865134c1d26b1880248a6795604 on noDeferred into 935e6b92279dbe398bb9df7dbd33e95453c6d062 on master.