Open meetmangukiya opened 4 years ago
Not sure how the coverage got decreased since we are just importing the whole module for giving an illusion of coverage(I think)?
Also, can we have a release after this is merged @chafey(mentioning for notification since no new commit in last 6 months and you are mentioned as package author) ?
In the meanwhile if anyone wishes to use this I've published it to github package - https://github.com/flamy-dev/cornerstoneWebImageLoader/packages/297934
This change would be extremely useful. Thanks @meetmangukiya @coveralls It's quite obvious that this PR can't affect your tests.
What do expect me to do in order to help with merging this one?
@Inzeppelin don't think this is going to be merged, better fork
Register
blob
as scheme instead ofblob:http
orblob:https
because cornerstone-core splits on:
and uses the first part as the scheme. So, if provided a urlblob:https://github.com/test-id
it will considerblob
as the scheme instead ofblob:https
.Closes https://github.com/cornerstonejs/cornerstoneWebImageLoader/issues/13