search

cornerstonejs / dicomParser

JavaScript parser for DICOM Part 10 data
MIT License
720 stars 230 forks source link

dicomParser is including node.js buffer code #148

Closed chafey closed 3 years ago

chafey commented 4 years ago

While inspecting the source for https://rawgit.com/cornerstonejs/dicomParser/master/examples/dumpWithDataDictionary/index.html, I noticed in the network debug window that dicomParser.min.js was 159K, much larger than I expected. I looked at the resonse tab and noticed a copyright notice for a node.js buffer module which is not needed for the browser version at least, since it uses TypedArrays. This likely got added as part of the change to WebPack. @dannyrb

dannyrb commented 4 years ago

related:

  1. https://github.com/webpack/webpack/issues/4872
  2. https://stackoverflow.com/questions/36439872/webpack-includes-unused-library-in-bundle-js/42744989