search

cornerstonejs / dicomParser

JavaScript parser for DICOM Part 10 data
MIT License
720 stars 230 forks source link

Updated TS definition #155

Closed liamcarter111 closed 4 years ago

liamcarter111 commented 4 years ago

This PR fixes TypeDoc generation for projects with dicomParser dependency.

The following error was occurring:

yarn run v1.22.4
$ typedoc

Using TypeScript 3.9.7 from /project/node_modules/typescript/lib
Error: /project/dicom-parser/index.d.ts(103)
 Construct signature, which lacks return-type annotation, implicitly has an 'any' return type.
error Command failed with exit code 4.

Resolved this issue by adding constructor return type to ByteStream.

$ typedoc

Using TypeScript 3.9.7 from /project/node_modules/typescript/lib
Rendering [========================================] 100%

Documentation generated at /project/docs

Done in 8.18s.
coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 52.759% when pulling f25472e916faed0a9c1420c42d9d27267a2ce0c9 on liamcarter111:patch-1 into 1cdf410b77c401be018c41b7c1aa20a89d613ad2 on cornerstonejs:master.

ohif-bot commented 4 years ago

:tada: This PR is included in version 1.8.7 :tada:

The release is available on:

Your semantic-release bot :package::rocket: