cornerstonejs / dicomParser

JavaScript parser for DICOM Part 10 data
MIT License
712 stars 228 forks source link

Need help in latest version 1.8.20 is not showing latest changes from master #236

Closed vmahajanarthrex closed 1 year ago

vmahajanarthrex commented 1 year ago

Latest package 1.8.20 https://www.npmjs.com/package/dicom-parser is not reflecting changes from index.d.ts

Latest package 1.8.20 shows file index.d.ts line 104 as

constructor(byteArrayParser: ByteArrayParser, byteArray: ByteArray, position: number): ByteStream;

However on master branch https://github.com/cornerstonejs/dicomParser/blob/master/index.d.ts#L104

we have constructor(byteArrayParser: ByteArrayParser, byteArray: ByteArray, position: number);

is there plan to publish this change ? if yes when that will be available in npm ?

on higher version of node 18 & typescript , its not working & getting error Error: node_modules/dicom-parser/index.d.ts:104:92 - error TS1093: Type annotation cannot appear on a constructor declaration.

knopkem commented 1 year ago

+1

keean commented 1 year ago

+1

knopkem commented 1 year ago

Until fixed: https://www.npmjs.com/package/@knopkem/dicom-parser

yagni commented 1 year ago

Should be fixed in latest release (1.8.21). Please reopen if that isn't the case. Thanks!