cornerstonejs / dicomParser

JavaScript parser for DICOM Part 10 data
MIT License
712 stars 228 forks source link

bug : attributeTag returns undefined if attribut has more then one reference #253

Open Ragnar-Oock opened 1 year ago

Ragnar-Oock commented 1 year ago

Some Data Elements with VR AT have a Value Multiplicity of 1-n, meaning they can have more than one value stored inside. However, the code and the comment on the function hint at an undefined return if the value length is strictly different then 4 bytes long.

code in question : https://github.com/cornerstonejs/dicomParser/blob/b7755a8d81221f777a1b71926b6ab8ed7dcc0976/src/dataSet.js#L275

examples of attribute of VR AT with a VM of 1-n : (0028,0009) Frame Increment Pointer (0028,000A) Frame Dimension Pointer

possible solutions :