search

cornfeedhobo / ssh-keydgen

Generate Deterministic SSH keys
Apache License 2.0
41 stars 9 forks source link

Fixes app name #9

Closed nkakouros closed 5 years ago

cornfeedhobo commented 5 years ago

Sorry, this is called keydgen on purpose, but thank you for the PR.

nkakouros commented 5 years ago

I understand the naming os ssh-keydgen, but in the code there are places where you call the app ssh-keygen instead of `ssh-keydgen. Is this on purpose?

cornfeedhobo commented 5 years ago

@tterranigma My sincere apologies. I see what you mean. My first pass glance at this PR saw it as the inverse of your suggestion. Indeed this would be nice to fix. Unfortunately I am archiving this repo most likely. I was naive and wrote this too tightly coupled to Go's implementation of key generation, making the keys non-deterministic in later versions. I'm currently researching the SSH key generation process to see if I can roll a better implementation of this which I will validate with a python library that does the same.

nkakouros commented 5 years ago

I wish you the best of luck as this project has been really useful so far!