corollari / ankiTab

Browser extension that replaces the new tab page with Anki flashcards
https://ankitab.com
The Unlicense
187 stars 16 forks source link

Link to Firefox package not working #17

Closed lieuzhenghong closed 5 years ago

lieuzhenghong commented 5 years ago

Have seen issue #6 and #3. The link given in #3 [post here] is no longer working, and neither is the one in README.md.

Where can I download the package?

Thanks very much.

Sincerely Zhenghong

corollari commented 5 years ago

I'll look into it right now. Thanks for the heads up :+1:

corollari commented 5 years ago

After looking at it more closely, it seems the extension was banned from the firefox store 15 days ago due to two reasons unrelated to #3 and #6:

  1. Use of an alpha release of bootstrap (it seems developers are only allowed to use stable versions [1])
  2. Use of a slightly modified copy of jquery

Regarding reason 2, this addon removed all dependencies on jquery, and jquery itself, about 7 months ago (see a9fabd1c45a81dec28b5c6e5788c1a61993a77cf) so I'm not really sure what to make of this.

Anyway, I'll update bootstrap to a stable version and resubmit the extension while sacrificing a lamb to appease the gods.

[1] According to the rules "Note that non-release versions of third-party libraries are not accepted.", so, is an alpha release considered a non-release version? It seems so.

corollari commented 5 years ago

Closing because this was solved 5 days ago.