search

corollari / ankiTab

Browser extension that replaces the new tab page with Anki flashcards
https://ankitab.com
The Unlicense
187 stars 16 forks source link

Sandbox card HTML in order to allow running JavaScript on cards #21

Closed throwaway020863029 closed 5 years ago

throwaway020863029 commented 5 years ago

Fix #14

corollari commented 5 years ago

Thanks for the PR! Just tested it and works like a charm.

corollari commented 5 years ago

Given that Firefox doesn't support sandboxing I'll finally have to develop a proper build system for the extension. As you developed this part, if you have some opinion on how to go about developing that system or how to port this PR's functionality to firefox I'd love to hear your thoughts on it.

Also, given that it seems you have created a throwaway account just for this PR. If it's more comfortable for you to send patches to me via email, that's fine for me, I'll just push them to the GH repo.