Improved Dark Theme (cards now white-on-black text) and max-image widths

corollari / ankiTab

Browser extension that replaces the new tab page with Anki flashcards

https://ankitab.com

The Unlicense

187 stars 16 forks source link

Improved Dark Theme (cards now white-on-black text) and max-image widths #33

Closed adammesa closed 2 years ago

adammesa commented 2 years ago

This PR is in direct response to

https://github.com/corollari/ankiTab/issues/11 (max image-width for those of us who have retina-sized screenshots on our cards that are otherwise too big and require a lot of side-to-side scrolling)
https://github.com/corollari/ankiTab/issues/31
bumped version to v0.5.4

See attached .zips for the .bash generated extensions (unsigned, not yet on webstore) firefox.zip chrome.zip

adammesa commented 2 years ago

Found a bug, (de-synchronized dark-theme), will fix and resubmit.

EDIT: unable to reproduce bug on further testing. (dark-theme applies to anki card but not container, or vice-versa. If anyone has steps to reproduce it, I'll do my best to fix it. May have just been caused when looking at an old dev environment. Logic looks fine.)

adammesa commented 2 years ago

@corollari any changes you would like seen to this edit? Need any help preparing it for the webstore?

adammesa commented 2 years ago

I was able to reproduce the bug:

enable dark mode
close the tab, open a new tab
background has dark mode enabled, the inner card for whatever reason has defaulted to light mode

Will close this PR and submit a new fixed one with the identical version.