Privacy policy not displayed correctly on old devices

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

2.44k stars 495 forks source link

Privacy policy not displayed correctly on old devices #3166

Closed fynngodau closed 2 years ago

fynngodau commented 3 years ago

Technical details

Android version: API 23 / Android 6
App version: 2.2.x

Describe the bug

The ordered list is not parsed correctly by the platform HTML parser on old Android versions.

Result on API 23	Result on API 28

Steps to reproduce the issue

View privacy policy on affected platform versions.

Expected behaviour

Display text correctly. Possibly also show numbers in front of the ordered list?

Possible fixes

Remove ordered list
Use custom tag handler such as this one: https://bitbucket.org/Kuitsi/android-textview-html-list/src/master/app/src/main/java/fi/iki/kuitsi/listtest/MyTagHandler.java

Additional context

Regression in 2.2.x due to a change in the privacy policy that added an ordered list instead of p tags.

Internal Tracking-ID: EXPOSUREAPP-7268

heinezen commented 3 years ago

@fynngodau

Thank you. The issue has been reported to the devs (EXPOSUREAPP-7268).

Corona-Warn-App Open Source Team

MikeMcC399 commented 3 years ago

Is this supposed to have been fixed in the release/2.3.x branch or is it still a work-in-progress? The changes which have been made so far in the release/2.3.x branch don't solve the issue well and have not returned the display of the privacy policy to the clean status it had in the 2.1 release.

Using release/2.3.x to view the English language privacy policy:

on API 23 there are no line breaks between each entry in the table of contents list
on API 30 there is an extra bullet before the number of each entry in the table of contents list

Perhaps it is time to revert to 2.1.x formatting?

release/2.3.x on API 23

release/2.3.x on API 30

released version 2.1.2 on API 23

heinezen commented 3 years ago

@MikeMcC399 It's still work in progress. We don't know if it will be fixed in 2.3 yet.

Corona-Warn-App Open Source Team

MikeMcC399 commented 2 years ago

See PR #5502 (replaces #5498 which caused some regressions and was not merged).

MikeMcC399 commented 2 years ago

This should be fixed when 2.27 is released. In the current 2.27.0-RC3 version it looks like this:

Result on API 23 Android 6.0	Result on API 28 Android 9.0