search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

[HELP WANTED][README] Text / Translations #332

Closed marcmuschko closed 2 years ago

marcmuschko commented 4 years ago

Dear contributers,

as we are getting into the final stage regarding all texts and translations within the app, we would appreciate your support in this area! If you spot anything unsual within the German / English text files, please report your findings as a comment in this issue.

Since the texts and translations are not provided by the development team but by a dedicated stream and have to be approved by the stakeholders first (depending on the change), it is easier for the stream to check this issue for findings and provide fixes when necessary. Please don't create pull requests directly, the string files will be overwritten when we import changes from our translation stream.

Edited (after we noticed several findings within legal texts and we aspire to be as transparent as possible): Please be aware that all legal texts including their translations (Terms of Use, Publication Details, Data Privacy Information, Legal Notices) are handled separately, Neither developers nor the text / translation stream have any influence on spelling or wording, as these texts require dedicated approval. We will certainly collect your suggestions and pass them on, but it can take time until improvements are included (if at all).

Thank you for your your help! Best regards, Marc

marcmuschko commented 4 years ago

Referencing findings from issue #72

mh- commented 4 years ago

Privacy notice: "..., versendet Ihr Smartphone per Bluetooth Low Energy kontinuierlich zufallsgenerierte Kennnummern, auch als Zufallscodes zu bezeichnet" - remove the word "zu"

Privacy notice in Android app has not yet been updated.

mh- commented 4 years ago

Link to Privacy Notice in Terms does not work: 

Die separate Datenschutzerklärung (siehe <strong>[<em>Link</em>]</strong>) ist
Bestandteil dieser Nutzungsbedingungen.

(Other links don't work either: Weiterführende Informationen zur App finden Sie unter folgendem Link: <strong>[<em>Link</em>]</strong>)

Emphasis wrong:

In regelmäßigen Abständen holt sich die App über die CWA-Dienste eine Liste der Zufallscodes (<em>t</em> <em>emporary exposure keys</em>)

The text contains symbols (emoticons?) that cannot be displayed by all devices

� - Waschen Sie sich regelmäßig für mindestens 20 Sekunden die Hände

There's a text block in the middle of the Terms that apparently ends the 'official' part: 

Diese weiterführenden Informationen dienen lediglich Ihrer Information und 
sind nicht Bestandteil dieser Nutzungsbedingungen.

but I don't think that's intended, because a lot of important points follow. It's completely unclear when the "weiterführenden Informationen" end.

bocops commented 4 years ago

The abbreviation "CWA" is only used once in user-facing strings of the Android app, in

<string name="main_overview_body_glossary_keys">"Die Zufallscodes sind zufällig erzeugte Zahlen- und Buchstabenkombinationen. Sie werden zwischen benachbarten Smartphones ausgetauscht. Zufallskennungen lassen sich nicht einer bestimmten Person zuordnen und werden nach 14 Tagen automatisch gelöscht. Eine Corona-positiv getestete Person kann ihre Zufallscodes der letzten bis zu 14 Tage freiwillig mit anderen CWA-Nutzern teilen."</string>

Unexplained abbrevations can be confusing.

Suggestion: change last part to "[...] freiwillig mit anderen Nutzern der Corona-Warn-App teilen."

mh- commented 4 years ago

The Terms text gives incorrect statements about the app:

Hintergrund
Die App läuft auf dem Endgerät im Hintergrund und speichert automatisiert
und verschlüsselt die Zufallscodes (<em>rolling proximity identifier</em>)
anderer in der Nähe befindlicher Endgeräte. In regelmäßigen Abständen holt
sich die App über die CWA-Dienste eine Liste der Zufallscodes (<em>t</em> <em>emporary 
exposure keys</em>) der Personen, die sich freiwillig infiziert gemeldet haben, und vergleicht 
diese mit den gespeicherten Zufallscodes im Gerät, um eine Risiko-Begegnung zu ermitteln.

a) The word "Zufallscodes" is translated to two different things (RPI and TEK). b) The app does not save RPIs of other devices. The Google/Apple framework does that. c) At least the Google framework does not save the RPIs encrypted. Access to them is restricted, but they are not encrypted; the Terms should make a correct statement about that, or no statement at all.

My proposal for this text would be: 

Hintergrund
Die App aktiviert die Kontaktaufzeichnungs-Funktion Ihres Smartphones, 
die automatisiert abgeleitete Zufallscodes (<em>rolling proximity identifiers</em>) 
anderer in der Nähe befindlicher Endgeräte speichert. 
In regelmäßigen Abständen holt sich die App über die CWA-Dienste eine Liste von 
Zufallscodes (<em>temporary exposure keys</em>) der Personen, die sich freiwillig 
infiziert gemeldet haben, und übergibt sie der Kontaktaufzeichnungs-Funktion Ihres 
Smartphones, welche durch Vergleiche mit den im Gerät gespeicherten Zufallscodes 
ermittelt, ob Risiko-Begegnungen stattgefunden haben.
mh- commented 4 years ago

The Terms make incorrect statements about how to disable Exposure Notifications.

    Wenn Sie die App
    nicht starten, ausschalten oder beenden, speichert die App keine
    Begegnungen mit anderen Personen und erzeugt keine Zufallscodes zur
    Speicherung durch andere Personen.

Obviously the lawyer intended to inform users who don't properly run the app, that they might miss notifications. But users who are later concerned about their privacy and want to disable the feature could also think that just stopping the app could achieve that. But it doesn't, they would need to explicitly stop Exposure Notifications. And it's anyway not the App that does all that. So the text should read:

    Wenn Sie die App
    nicht starten, ausschalten oder beenden, speichert _das Gerät möglicherweise_ keine
    Begegnungen mit anderen Personen und erzeugt _möglicherweise_ keine Zufallscodes zur
    Speicherung durch andere Personen.
mh- commented 4 years ago

Onboarding text here and here - and probably also for iOS contains an incorrect statement:

Die Personen, deren verschlüsselte Zufallscodes Sie gesammelt haben, erhalten nun eine Warnung

This is incorrect and somehow implies that my smartphone has knowledge about the users whose RPIs it has collected and can warn them. But that's not the case for privacy reasons. The text should read:

Die Personen, die Ihre verschlüsselten Zufallscodes gesammelt haben, erhalten nun eine Warnung
mh- commented 4 years ago

@marcmuschko Will you sync these corrections also to the iOS app?

marcmuschko commented 4 years ago

@mh- Absolutely, you do not have to report the findings twice! Our colleagues are monitoring both text correction threads for iOS and Android, therefore the findings should be synced accordingly.

mh- commented 4 years ago

Repetition in English translation: https://github.com/corona-warn-app/cwa-app-android/blob/master/Corona-Warn-App/src/main/res/values-en/strings.xml

<!-- XMSG: Dialog body for already paired test error -->
    <string name="submission_error_dialog_web_test_paired_body">"The QR code/TAN is invalid or has been used already. The TAN is invalid or has been used already. Please try again or contact the technical hotline via App Information -&gt; Technical Hotline."</string>

The second "The TAN is invalid or has been used already." should be removed.

dadosch commented 4 years ago
jschleus commented 4 years ago

As the project is entering the final phase, I would like to point out that similar to the description in the issue cwa-app-ios#149 there exists on the FOSS server fossies.org also a regularly updated codespell report for "cwa-app-android":

  https://fossies.org/linux/test/cwa-app-android/codespell.html

That analysis checks not only the user visible output strings but also the code itself and according comments. But it is simply dictionary based (English only) and just word oriented.

Only few errors were found (the word tage wasn't yet excluded as a FP since it seems a German spelling error -> Tage).

By the way, skimming manually over the file Corona-Warn-App/src/main/res/values/strings.xml I found German misspellings, missing spaces and sometimes vowels in place of the expected mutated vowels ("umlauts"). But all that errors are corrected in the corresponding German specific file Corona-Warn-App/src/main/res/values-de/strings.xml (that seems to have still much more ihre -> Ihre errors than those already mentioned in the previous comment).

jenderny commented 4 years ago

The error dialogue that pops up when someone has entered an invalid or already used QR code or TAN tells the user where to find the the hotline (App-Informationen → Technische Hotline). The user might have problems to find this information, because it's a little hidden in a submenu on another page. For better user experience the dialogue should get an additional button that links directly to the page Technische Hotline.

The dialogue text could than be shortened to

Der QR-Code / Die TAN ist ungültig oder wurde schon verwendet. Bitte versuchen Sie es erneut oder kontaktieren Sie die technische Hotline. with the buttons Zur technischen Hotline Zurück

mlenkeit commented 4 years ago
jwaciewski commented 4 years ago

https://github.com/corona-warn-app/cwa-app-android/blob/970e8b859cff3c8beeca83ac83e9ed534927107a/Corona-Warn-App/src/main/res/values-de/strings.xml#L358

https://github.com/corona-warn-app/cwa-app-android/blob/970e8b859cff3c8beeca83ac83e9ed534927107a/Corona-Warn-App/src/main/res/values-de/strings.xml#L840

https://github.com/corona-warn-app/cwa-app-android/blob/970e8b859cff3c8beeca83ac83e9ed534927107a/Corona-Warn-App/src/main/res/values-de/strings.xml#L228

JeWe94 commented 4 years ago

https://github.com/corona-warn-app/cwa-app-android/blob/970e8b859cff3c8beeca83ac83e9ed534927107a/Corona-Warn-App/src/main/res/values-en/strings.xml#L358

The String "onboarding_tracing_body_consent" is missing its English translation. In the iOS App it already seems to be translated: https://github.com/corona-warn-app/cwa-app-ios/blob/9b7601e37009c0baafeaea90d197a277e3b9d632/src/xcode/ENA/ENA/Resources/Localization/en.lproj/Localizable.strings#L189

Fixed with https://github.com/corona-warn-app/cwa-app-android/pull/421

jkoendev commented 4 years ago

mlenkeit commented:

Dativ: should be "[...] in dem Rahmen [...]" unless there are multiple "Rahmen" https://github.com/corona-warn-app/cwa-app-android/blob/cd6d6af76f06da6a56962fe2217b4ec036997536/Corona-Warn-App/src/main/res/values-de/strings.xml#L638

innerhalb des Rahmens oder einfach Scannen Sie den QR-Code

sschuett commented 4 years ago

<string name="onboarding_body">"Machen Sie Ihr Smartphone zum Corona-Warn-System. Überblicken Sie Ihren Risikostatus und erfahren Sie, ob in den letzten 14 Tagen Corona-positiv getestete Personen in Ihrer Nähe waren."</string>

(should be "in Ihrer Nähe" instead of "in ihrer Nähe")

timoguentner commented 4 years ago

In terms_de.html:

Sie besagt lediglich, dass sie während der letzten 14 Tage eine [...]

Should be: "Sie besagt lediglich, dass Sie während der letzten 14 Tage eine [...]"

Bitte prüfen Sie in den Einstellungen ihres Endgeräts, ob diese Funktionen

Should be: "Bitte prüfen Sie in den Einstellungen Ihres Endgeräts, ob diese Funktionen [...]"

Bananeweizen commented 4 years ago

German translation uses "nun" 2 times in the introduction for things that will happen in the future. The introduction says

...Personen...erhalten nun eine Warnung...

which can easily be misread as "an alert is sent right now". Just replace "nun" by "dann" to avoid the confusion.

Affected lines: https://github.com/corona-warn-app/cwa-app-android/blob/c3416440e644a918f4001489de85f203c7681099/Corona-Warn-App/src/main/res/values-de/strings.xml#L386 https://github.com/corona-warn-app/cwa-app-android/blob/c3416440e644a918f4001489de85f203c7681099/Corona-Warn-App/src/main/res/values-de/strings.xml#L388

fusselkater commented 4 years ago

The text "Wurden Sie getestet?" should be something like "Wurden Sie positiv getestet?", I was wondering if I have to send my negative test result.

jwaciewski commented 4 years ago

The text "Wurden Sie getestet?" should be something like "Wurden Sie positiv getestet?", I was wondering if I have to send my negative test result.

You probably should share your test result regardless of its result

fusselkater commented 4 years ago

The text "Wurden Sie getestet?" should be something like "Wurden Sie positiv getestet?", I was wondering if I have to send my negative test result.

You probably should share your test result regardless of its result

That makes no sense and would block resources on the hotline

FWCologne commented 4 years ago

Concerning my pull request mentioned above: in Corona-Warn-App/src/main/assets/terms_de.html it says in line 462

Bitte prüfen Sie in den Einstellungen ihres Endgeräts, ob diese Funktionen aktiviert und für die Verwendung der App freigegeben sind.

"ihres" should start with a capital "I".

EliasHolzmann commented 4 years ago

In your data privacy policy, you write "Den Datenschutzbeauftragten des RKI erreichen Sie unter der oben genannten Anschrift (zu Händen "Behördlicher Datenschutzbeauftragter") und per E-Mail an: datenschutz@rki.de)"

That second closing bracket does not match.

orrc commented 4 years ago

After installing the app, I noticed this slight inconsistency in the onboarding flow.

There's a big button called "Activate Exposure Logging", however the text above refers to it as simply the "Enable" button:

By tapping on the “Enable” button, you agree to …

https://github.com/corona-warn-app/cwa-app-android/blob/c3416440e644a918f4001489de85f203c7681099/Corona-Warn-App/src/main/res/values/strings.xml#L365-L368

The German version looks fine (i.e. the body text and button title match).

nohn commented 4 years ago

Clarify "Mundschutz". Should be "Mund-Nasen-Schutz".

designrDevelopr commented 4 years ago

When copying text from a PDF into a text editor, ü gets copied as ü, which looks the same in most font faces, but is an u and a ¨ with negative spacing. In the text editor this is indistinguishable, but in the webfont, it is displayed wrong (can’t attach screenshot, due to screenshot-restrictions). There are 14 occurences of ü in the strings.xml (13 lowercase, 1 uppercase) https://github.com/corona-warn-app/cwa-app-android/compare/master...designrDevelopr:patch-1#diff-401494227159003b37a3e9f24a5b2d78

7horondor commented 4 years ago

The "wir" in https://github.com/corona-warn-app/cwa-app-android/blob/cacf64a4611c37bb062e7ee4d08822f9ba9d2662/Corona-Warn-App/src/main/res/values-de/strings.xml#L165 and https://github.com/corona-warn-app/cwa-app-android/blob/cacf64a4611c37bb062e7ee4d08822f9ba9d2662/Corona-Warn-App/src/main/res/values-de/strings.xml#L299 suggests that the risk isn't calculated on the device but somewhere else. I think this should be changed to something like "... konnte für Sie kein Infektionsrisiko berechnet werden."

opatut commented 4 years ago

I have to say, this app contains mostly gender neutral and inclusive language, which is refreshing and suprising. Thank you!

Looking through it, I just found a few more things that need adjustment.

  1. The following translation strings contain only masculine form of certain nouns or pronouns referencing people in the german translation texts (mainly "Nutzer", "sein"):

    • main_overview_body_glossary_keys
    • onboarding_tracing_body_consent
    • submission_positive_other_warning_privacy_body

    I understand that some of these are legal texts, which may take longer to process and that process might already be underway. If not, please consider changing those as well.

    Note: The first key (main_overview_body_glossary_keys) was referenced in a comment above because it contains an abbreviation that is not referenced or explained. Make sure to apply gender neutral language to the suggested change in that comment as well :)

  2. Some descriptions of illustrations use the words "Mann" and "Frau" or "sein" to reference humans in the picture. While those people may be drawn in a stereotypically male or female way, it is not generally possible to link people's gender or sex to their appearance. It is therefore not required to reference them in the caption as such, and doing so instead propagates the wrong assumption that third persons could perform such assignments. "Eine Person" would be a sufficient description of the characters in the illustrations:

    • submission_done_illustration_description
    • information_contact_illustration_description
    • main_share_illustration_description
    • onboarding_privacy_illustration_description
    • onboarding_notifications_illustration_description
    • settings_notifications_illustration_description_active
    • settings_notifications_illustration_description_inactive
    • information_privacy_illustration_description
mh- commented 4 years ago

I think that the English translation "Exposure Logging" for "Risiko-Ermittlung" is very problematic. The problem is that the user will think that by disabling "Logging", the data collection of the mobile device is stopped. But it is not, only the efforts of the app to estimate risk are stopped. This should rather be translated by "Risk Estimation".

ironjan commented 4 years ago

Phone in English.

  1. Go to "app information" - "publication details"

"Telefon" under "Contact" has not been translated. As most texts on this screen are translated, I expected this one too.

The same is true for "vertreten durch den Präsidenten" in "Published by". However, this could potentially be explained by legal requirements.

Affected lines:

bersbersbers commented 4 years ago

Clarify "Mundschutz". Should be "Mund-Nasen-Schutz".

Consider "Mund-Nasen-Bedeckung", compare https://github.com/corona-warn-app/cwa-app-android/issues/618#issuecomment-645774002

mlaue-tech-zz commented 4 years ago

<string name="submission_dispatcher_qr_card_text">"Registrieren Sie Ihren Test, indem Sie den QR-Code ihres Test-Dokuments scannen."</string> Should be: Registrieren Sie Ihren Test, indem Sie den QR-Code Ihres Test-Dokuments scannen.

The "I" in "ihres" should be in capital letters.

<string name="onboarding_test_body">"Ihre Mitteilung wird zuverlässig verschlüsselt über einen sicheren Server weiterverarbeitet. Die Personen, deren verschlüsselte Zufallscodes Sie gesammelt haben, erhalten nun eine Warnung und Informationen darüber, wie sie weiter vorgehen sollen."</string>

Should be: Ihre Mitteilung wird zuverlässig verschlüsselt über einen sicheren Server weiterverarbeitet. Die Personen, deren verschlüsselte Zufallscodes Sie gesammelt haben, erhalten nun eine Warnung und Informationen darüber, wie Sie weiter vorgehen sollen.

The "S" in "sie" should be in capital letters.

<string name="submission_positive_other_warning_privacy_body">"Durch Antippen von „Weiter“ willigen Sie ein, dass die App Ihr positives Testergebnis zusammen mit Ihren Zufalls-IDs der letzten 14 Tage an das Serversystem der App übermittelt, damit andere App-Nutzer mit aktivierter Risiko-Ermittlung automatisch informiert werden können, dass sie möglicherweise einem Infektionsrisiko ausgesetzt waren. Die übermittelten Zufalls-IDs enthalten keine Angaben, die Rückschlüsse auf Ihre Identität oder Ihre Person zulassen.\n\nDie Übermittlung Ihres Testergebnisses per App ist freiwillig. Wenn Sie Ihr Testergebnis nicht übermitteln, entstehen Ihnen keine Nachteile. Da weder nachvollzogen noch kontrolliert werden kann, ob und wie Sie die App verwenden, erfährt außer Ihnen niemand, ob Sie eine Infektion übermittelt haben.\n\nSie können Ihre Einwilligung jederzeit widerrufen, indem Sie die App löschen. Durch den Widerruf der Einwilligung wird die Rechtmäßigkeit der aufgrund der Einwilligung bis zum Widerruf erfolgten Verarbeitung nicht berührt. Weitere Informationen finden Sie unter dem Menüpunkt „Datenschutzinformation“."</string>

Should be: Durch Antippen von „Weiter“ willigen Sie ein, dass die App Ihr positives Testergebnis zusammen mit Ihren Zufalls-IDs der letzten 14 Tage an das Serversystem der App übermittelt, damit andere App-Nutzer mit aktivierter Risiko-Ermittlung automatisch informiert werden können, dass Sie möglicherweise einem Infektionsrisiko ausgesetzt waren. Die übermittelten Zufalls-IDs enthalten keine Angaben, die Rückschlüsse auf Ihre Identität oder Ihre Person zulassen.\n\nDie Übermittlung Ihres Testergebnisses per App ist freiwillig. Wenn Sie Ihr Testergebnis nicht übermitteln, entstehen Ihnen keine Nachteile. Da weder nachvollzogen noch kontrolliert werden kann, ob und wie Sie die App verwenden, erfährt außer Ihnen niemand, ob Sie eine Infektion übermittelt haben.\n\nSie können Ihre Einwilligung jederzeit widerrufen, indem Sie die App löschen. Durch den Widerruf der Einwilligung wird die Rechtmäßigkeit der aufgrund der Einwilligung bis zum Widerruf erfolgten Verarbeitung nicht berührt. Weitere Informationen finden Sie unter dem Menüpunkt „Datenschutzinformation“.

The "S" in "sie" should be in capital letters.

nicktar commented 4 years ago

From #672:

For an exposure to show up in the app there is a couple of additional requirements that don't change the risk of an infection like the infected needs to use the app, has to be tested and has to share the test results. While the numbers will hopefully improve, this gives an estimated probability of an exposure to show up in the app of currently below 10%. Stating "no exposures" might lead to the wrong conclusion of "the app told me I'm not infected" and probably reduced safety measured because of that.

Proposed change of wording "No exposures up to now" => "No known exposures up to now"

And from #640 "Low Risk" in home screen suggest that the app can guarantee safety. Rather use "App did not detect a source of risk" or similar instead.

MilesTeg97 commented 4 years ago

simple typo in terms_en.html:

line 408: "The App muss must be running on your device [...]"

should be: "The App must be running on your device [...]"

kaluju commented 4 years ago

Privacy notice: "..., versendet Ihr Smartphone per Bluetooth Low Energy kontinuierlich zufallsgenerierte Kennnummern, auch als Zufallscodes zu bezeichnet" - remove the word "zu"

Privacy notice in Android app has not yet been updated.

--> Unfortunately, this is a legal text and it can't be changed by me directly. I have forwarded the comment to the people responsible.

kaluju commented 4 years ago

Link to Privacy Notice in Terms does not work:

Die separate Datenschutzerklärung (siehe <strong>[<em>Link</em>]</strong>) ist
Bestandteil dieser Nutzungsbedingungen.

(Other links don't work either: Weiterführende Informationen zur App finden Sie unter folgendem Link: <strong>[<em>Link</em>]</strong>)

Emphasis wrong:

In regelmäßigen Abständen holt sich die App über die CWA-Dienste eine Liste der Zufallscodes (<em>t</em> <em>emporary exposure keys</em>)

The text contains symbols (emoticons?) that cannot be displayed by all devices

� - Waschen Sie sich regelmäßig für mindestens 20 Sekunden die Hände

There's a text block in the middle of the Terms that apparently ends the 'official' part:

Diese weiterführenden Informationen dienen lediglich Ihrer Information und 
sind nicht Bestandteil dieser Nutzungsbedingungen.

but I don't think that's intended, because a lot of important points follow. It's completely unclear when the "weiterführenden Informationen" end.

--> Unfortunately, this is a legal text and it can't be changed by me directly. I have forwarded the comment to the people responsible.

kaluju commented 4 years ago

The Terms text gives incorrect statements about the app:

Hintergrund
Die App läuft auf dem Endgerät im Hintergrund und speichert automatisiert
und verschlüsselt die Zufallscodes (<em>rolling proximity identifier</em>)
anderer in der Nähe befindlicher Endgeräte. In regelmäßigen Abständen holt
sich die App über die CWA-Dienste eine Liste der Zufallscodes (<em>t</em> <em>emporary 
exposure keys</em>) der Personen, die sich freiwillig infiziert gemeldet haben, und vergleicht 
diese mit den gespeicherten Zufallscodes im Gerät, um eine Risiko-Begegnung zu ermitteln.

a) The word "Zufallscodes" is translated to two different things (RPI and TEK). b) The app does not save RPIs of other devices. The Google/Apple framework does that. c) At least the Google framework does not save the RPIs encrypted. Access to them is restricted, but they are not encrypted; the Terms should make a correct statement about that, or no statement at all.

My proposal for this text would be:

Hintergrund
Die App aktiviert die Kontaktaufzeichnungs-Funktion Ihres Smartphones, 
die automatisiert abgeleitete Zufallscodes (<em>rolling proximity identifiers</em>) 
anderer in der Nähe befindlicher Endgeräte speichert. 
In regelmäßigen Abständen holt sich die App über die CWA-Dienste eine Liste von 
Zufallscodes (<em>temporary exposure keys</em>) der Personen, die sich freiwillig 
infiziert gemeldet haben, und übergibt sie der Kontaktaufzeichnungs-Funktion Ihres 
Smartphones, welche durch Vergleiche mit den im Gerät gespeicherten Zufallscodes 
ermittelt, ob Risiko-Begegnungen stattgefunden haben.

--> Unfortunately, this is a legal text and it can't be changed by me directly. I have forwarded the comment to the people responsible.

kaluju commented 4 years ago

The abbreviation "CWA" is only used once in user-facing strings of the Android app, in

<string name="main_overview_body_glossary_keys">"Die Zufallscodes sind zufällig erzeugte Zahlen- und Buchstabenkombinationen. Sie werden zwischen benachbarten Smartphones ausgetauscht. Zufallskennungen lassen sich nicht einer bestimmten Person zuordnen und werden nach 14 Tagen automatisch gelöscht. Eine Corona-positiv getestete Person kann ihre Zufallscodes der letzten bis zu 14 Tage freiwillig mit anderen CWA-Nutzern teilen."</string>

Unexplained abbrevations can be confusing.

Suggestion: change last part to "[...] freiwillig mit anderen Nutzern der Corona-Warn-App teilen."

--> changed to App-Nutzern

kaluju commented 4 years ago
  • <string name="risk_card_body_tracing_off">"Aktivieren Sie die Risiko-Ermittlung, um Ihre heutige Risikostatus zu berechnen."</string> :heutige should be heutigen, and Ihre Ihren
  • In submission_contact_step_1_content: "Es gelten die Preise ihres Telefonanbieters." should be "Es gelten die Preise Ihres Telefonanbieters." --> text no longer exists
  • In submission_done_further_info_bullet_points: "wie sich ihre Krankheitszeichen entwickeln." should be "wie sich Ihre Krankheitszeichen entwickeln." --> changed to "Ihre"
kaluju commented 4 years ago

The Terms make incorrect statements about how to disable Exposure Notifications.

    Wenn Sie die App
    nicht starten, ausschalten oder beenden, speichert die App keine
    Begegnungen mit anderen Personen und erzeugt keine Zufallscodes zur
    Speicherung durch andere Personen.

Obviously the lawyer intended to inform users who don't properly run the app, that they might miss notifications. But users who are later concerned about their privacy and want to disable the feature could also think that just stopping the app could achieve that. But it doesn't, they would need to explicitly stop Exposure Notifications. And it's anyway not the App that does all that. So the text should read:

    Wenn Sie die App
    nicht starten, ausschalten oder beenden, speichert _das Gerät möglicherweise_ keine
    Begegnungen mit anderen Personen und erzeugt _möglicherweise_ keine Zufallscodes zur
    Speicherung durch andere Personen.

--> Unfortunately, this is a legal text and it can't be changed by me directly. I have forwarded the comment to the people responsible.

opatut commented 4 years ago

--> changed to App-Nutzern

This is unfortunately not gendered appropriately. Please change to Nutzerinnen und Nutzern der App or similar.

kaluju commented 4 years ago

simple typo in terms_en.html:

line 408: "The App muss must be running on your device [...]"

should be: "The App must be running on your device [...]"

--> Unfortunately, this is a legal text and it can't be changed by me directly. I have forwarded the comment to the people responsible.

kaluju commented 4 years ago

  • [ ] Zufallscodes vs. Zufalls-ID vs. Zufalls-Kennung: all are used, should be reviewed and potentially harmonized --> Unfortunately, this inconsistency concerns legal texts and it can't be changed by me directly. I have forwarded the comment to the people responsible.**

  • [ ] Ellipsis vs. three dots: should be reviewed --> Unfortunately, our translation system can't deal with unicode characters correctly, that's why there is an inconsistency

  • [ ] Corona-Virus (with dash) vs. Coronavirus (no dash) --> Unfortunately, this inconsistency concerns legal texts and it can't be changed by me directly. I have forwarded the comment to the people responsible.

kaluju commented 4 years ago
  • [ ] Um die Risiko-Ermittlung nutzen zu können müssen Sie zudem auf Ihrem Smartphone die von Google bereitgestellte Kontaktaufzeichnungs-Funktion „Benachrichtigungen zu möglicher Begegnung mit COVID-19-Infizierten“ aktivieren und für die Corona-Warn-App freigeben." missing comma after "Um die Risiko-Ermittlung nutzen zu können" --> Unfortunately, this is a legal text and it can't be changed by me directly. I have forwarded the comment to the people responsible.
kaluju commented 4 years ago

@marcmuschko I tried to answer all the feedback we got and I incorporated it. In my opinion, we could close this issue.

nicktar commented 4 years ago

@marcmuschko I tried to answer all the feedback we got and I incorporated it. In my opinion, we could close this issue.

Is there any response to https://github.com/corona-warn-app/cwa-app-android/issues/332#issuecomment-646794139?

opatut commented 4 years ago

I tried to answer all the feedback we got and I incorporated it. In my opinion, we could close this issue.

I still don't see an answer to my suggestions and/or the changes incorporated into the dev branch. Also some other people's suggestions that I checked are not included. Is dev the right branch to look on? If so, where are these changes?

ironjan commented 4 years ago

@opatut the dev branch would be the correct one. However, based on @kaluju's comments and the previous procedure for text changes, I assume something like the following process:

  1. "Bugs" in the texts are collected via #332
  2. The suggested changes are processed internally (which may or may not involve the legal department, based on the type of text)
  3. The changes are then applied to the app internally
  4. A final review on the all or only the changed texts marks them as "good"
  5. The translations are updated and reviewed (essentially 2-4 again)
  6. All texts are updated into dev at once

Steps 2-5 are most likely done via an internal toolchain which explains the many comments in the string files (e.g. the comment XBUT: risk card - update […] denotes that the text is on a button within a risk card that triggers the update […] action - this is important information for the language department which perhaps does not work on the code directly).