search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

App shows "Full vaccination protection in 0 days" on day 14 after the last shot #3561

Closed Ein-Tim closed 3 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

On day 14 after the last vaccination shot was received, the app shows "Full vaccination protection in 0 days". Here's a screenshot: image

Steps to reproduce the issue

  1. Get your second vaccination shot
  2. Wait 14 days or change the system time to 14 days in the future
  3. See that the app shows "Full vaccination protection in 0 days"

Expected behaviour

There shouldn't be the number "0" - this is not how we humans communicate 😁

Additional context

This bug report is based on the information a user shared on Twitter: https://twitter.com/stejormur/status/1409031782448705537?s=20

Internal Tracking-ID: EXPOSUREAPP-8121

In future it will show on the last day "Morgen/Tomorrow".

iOS PR corona-warn-app/cwa-app-ios#3029 Internal Tracking ID: EXPOSUREAPP-8157 R 2.5

Android PR #3575, https://github.com/corona-warn-app/cwa-app-android/pull/3567 Internal Tracking ID: EXPOSUREAPP-8158 R 2.4.3

heinezen commented 3 years ago

@Ein-Tim

Thanks for reporting. We are already investigating the issue internally.

Corona-Warn-App Open Source Team

DerVogel2020 commented 3 years ago

@Ein-Tim @heinezen

IMO under iOS the behaviour is correct. For me it shows 2 days while under Android the app shows 1 day.

guruguruguru commented 3 years ago

Screenshot_20210627-095323_Corona-Warn

This is what I got today.

MikeMcC399 commented 3 years ago

Internal Tracking ID: EXPOSUREAPP-7865 Android with PR https://github.com/corona-warn-app/cwa-app-android/pull/3467 corrected the problem of the vaccination status complete showing one day too early. Unfortunately the countdown was not changed at the same time.

It is clear reading the tests in https://github.com/corona-warn-app/cwa-app-android/blob/release/2.4.x/Corona-Warn-App/src/test/java/de/rki/coronawarnapp/covidcertificate/vaccination/core/VaccinatedPersonTest.kt that the countdown was not changed because in the test data it shows complete status on May 11, followed by immunity on May 12, however on May 11 the test expects 0 days (instead of 1 day) until immunity.

mawis commented 3 years ago

Ich habe das das gleiche Problem. Zertifikat sollte seit gestern, 2021-06-27 gültig sein, ist aber noch immer grau und „erst in 0 Tagen vollständig.” Der gleiche Text wurde auch gestern angezeigt.

CovPass dagegen zeigt das Zertifikat IMHO korrekt als gültigen, vollständigen Impfschutz an.

MikeMcC399 commented 3 years ago

@mawis

  1. Please confirm if you are using iOS or Android.
  2. Your screen shot shows a time of 01:08. Please check if you still get the same result later today, June 28, 2021. (I'm thinking it may be a timezone issue.)

We may need a separate new issue for your problem.

DerVogel2020 commented 3 years ago

As mentioned in https://github.com/corona-warn-app/cwa-documentation/issues/638#issuecomment-869143434 I can confirm that today the tile is still grey (which is correct), the counter decreased to 0 (in both: the tile and the text after tapping on the tile).

Under iOS the counter says "1" and the tile is still grey (both correct).

dsarkar commented 3 years ago

@DerVogel2020 @MikeMcC399 Thanks. Your info is forwarded to the internal ticket.

mawis commented 3 years ago

@MikeMcC399 Yes, I'm using the Android app. This morning the certificate changed to blue. Looking at the code, it probably has done so at 2 o'clock (= midnight UTC). So indeed there seems to be an issue with the used timezone.

@DerVogel2020 Looking at the “Verordnung zur Regelung von Erleichterungen und Ausnahmen von Schutzmaßnahmen zur Verhinderung der Verbreitung von COVID-19” it indeed seems to be correct, that the certificate gets valid at the date it now does (the 15th day after the vaccination). But the counter being shown is very confusing then. Telling the certificate gets valid in one day makes me think it's valid the next day. Telling that the certificate is valid in zero days, makes no sense to me at all.

Everything is especially confusing as the media always reported that the certificate gets valid after 14 (not 15) days. Even the following page of the RKI is explaining it incorrectly in that case:

From https://digitaler-impfnachweis-app.de/faq/:

Warum ist der QR-Code als Nachweis für den vollständigen Impfschutz erst nach 14 Tagen gültig? In Deutschland gelten Personen als geschützt, die mit einem in der EU zugelassenen COVID-19-Impfstoff geimpft wurden und bei denen nach Gabe der letzten Impfstoffdosis mindestens 14 Tage vergangen sind (Ausnahmen bzgl. Genesener siehe https://www.rki.de/SharedDocs/FAQ/COVID-Impfen/gesamt.html). Wenn Sie zum Beispiel die letzte notwendige Corona-Impfung am 01. Juni erhalten haben, dann ist der vollständige Corona-Impfschutz erst am 15. Juni erreicht.

Ein-Tim commented 3 years ago

@mawis

Could you open a new issue for the time zone bug? This has to be tracked separately (and again it has to be checked under iOS too).

Thank you!

mawis commented 3 years ago

@Ein-Tim Done, I opened a new issue for that: #3562

Ein-Tim commented 3 years ago

PR: https://github.com/corona-warn-app/cwa-app-android/pull/3567 will also fix this (day 0 will be shown as tomorrow).

DerVogel2020 commented 3 years ago

As mentioned in https://github.com/corona-warn-app/cwa-documentation/issues/638#issuecomment-869143434 I can confirm that today the tile is still grey (which is correct), the counter decreased to 0 (in both: the tile and the text after tapping on the tile).

Under iOS the counter says "1" and the tile is still grey (both correct).

And today the tile is blue and the counters are gone.👍🏻

dsarkar commented 3 years ago

FYI: In future it will show on the last day "Morgen/Tomorrow".

iOS PR https://github.com/corona-warn-app/cwa-app-ios/pull/3029 Internal Tracking ID: EXPOSUREAPP-8157 R 2.5

Android PR https://github.com/corona-warn-app/cwa-app-android/pull/3575, #3567 Internal Tracking ID: EXPOSUREAPP-8158 Internal Tracking ID: EXPOSUREAPP-8121 R 2.4.3

MikeMcC399 commented 3 years ago

CWA Android 2.4.3 has been released and is now in the Google Play Store.

DerVogel2020 commented 3 years ago

Works for me now!

Ein-Tim commented 3 years ago

After confirmation from @DerVogel2020, I assume that this has been fixed.

Closing as fixed.

dsarkar commented 3 years ago

Dear community, thanks for contributing!

Corona-Warn-App Open Source Team