search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

Transposed "Max, Mustermann" in screenshots #3994

Closed MikeMcC399 closed 3 years ago

MikeMcC399 commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

Screenshots generated by RecoveryCertificateDetailFragmentTest.kt and VaccinationDetailsFragmentTest.kt render the example name as "Max, Mustermann", where Name and First Name are transposed.

max mustermann

for example:

RecoveryCertificateDetailsFragment_recovered.png

VaccinationDetailsFragment_expired.png

Incorrect screenshots are currently also contained in the draft PR https://github.com/corona-warn-app/cwa-website/pull/1668 "Android Screenshots for Version: 2.9.0" for later publishing to https://www.coronawarn.app/en/screenshots/ when 2.9.x is released.

Steps to reproduce the issue

In CWA:

  1. Tap "Certificates" tab on Start Screen (tap "CONTINUE" if prompted)
  2. Tap "+ CERTIFICATE"
  3. Scan a valid vaccination certificate
  4. Check that the name under "Name, Vorname / Name, First Name" is rendered in that order

In Android Studio:

  1. Run RecoveryCertificateDetailFragmentTest.kt
  2. Run VaccinationDetailsFragmentTest.kt
  3. View > Tools Windows > Device File Explorer
  4. Go to /data/data/de.rki.coronawarnapp.test/screenshots
  5. Note that example name is incorrectly rendered as "Max, Mustermann"

Expected behavior

From CWA Android 2.7 onwards the formatting of the name was corrected for regular app usage, so screenshots should show the example name as "Mustermann, Max".

Possible Fix

In RecoveryCertificateDetailFragmentTest.kt and in VaccinationDetailsFragmentTest.kt

change every { fullNameFormatted } returns "Max, Mustermann" to every { fullNameFormatted } returns "Mustermann, Max"

Additional context

Issue https://github.com/corona-warn-app/cwa-app-android/issues/3692 "Vaccination Details Screen: Firstname Surname in wrong order" was fixed through PR https://github.com/corona-warn-app/cwa-app-android/pull/3826 which fixed the issue in CWA Android 2.7. for:

Internal Tracking ID: EXPOSUREAPP-9233

MikeMcC399 commented 3 years ago

Please let me know if you would like a PR to correct this issue.

dsarkar commented 3 years ago

@MikeMcC399 Thanks. I Will get back to about the PR. Internal Tracking ID: EXPOSUREAPP-9233

dsarkar commented 3 years ago

@MikeMcC399 Feedback from dev:

"That is fine, we can accept such PR "

MikeMcC399 commented 3 years ago

Draft PR #3997 is created. I want to add screenshots before submitting for review.

MikeMcC399 commented 3 years ago

Changed screenshots files now added to PR #3997 for verification.

MikeMcC399 commented 3 years ago

PR https://github.com/corona-warn-app/cwa-app-android/pull/3997 "Correct to "Mustermann, Max" in certificate screenshots (EXPOSUREAPP-9233) (COMMUNITY)" is merged and included in v2.9.0-RC1, ready for release with version 2.9.

dsarkar commented 3 years ago

@MikeMcC399 Thank you for the contribution!

MikeMcC399 commented 3 years ago

The issue has been corrected for Android screenshots for CWA 2.9 published today, Sept 8, 2021, for example:

and for future version screenshots.

dsarkar commented 3 years ago

@MikeMcC399 Thanks for confirming the fix. Forwarded to internal ticket.