Closed MikeMcC399 closed 3 years ago
@marcauberer This is the new issue, as you requested.
@MikeMcC399 Thanks for opening a separate issue: Internal Tracking ID: EXPOSUREAPP-9297.
@MikeMcC399 new pr is open. Would be nice, if you could take a look at the screenshots and report back to me if the bug is solved. Thank you!
@marcauberer
I'll be happy to check the screenshots, however currently on this branch and on release/2.10.x screenshot generation fails at PersonDetailsFragmentTest.kt
io.mockk.MockKException: no answer found for: TestCertificate(#41)
I will try to find out if I can go back to a commit in release/2.10.x where it still works.
it is already verified by @MikeMcC399 and can be closed
Successfully verified in branch release/2.10.x at commit https://github.com/corona-warn-app/cwa-app-android/commit/b2a35fbef27c2c9f2b6870a0592ad031d9e5a10e.
Pixel 3a API 30 (Android 11) emulator
PersonDetailsFragmentTest.kt
on emulator/data/data/de.rki.coronawarnapp.test/screenshots
Now closing, since the regression was only present in an unreleased version and the issue is fixed.
@marcauberer PR https://github.com/corona-warn-app/cwa-app-android/pull/4036 did not fix formatting the date-of-birth in certificates for locale English (United Kingdom). At the time that I closed this issue (https://github.com/corona-warn-app/cwa-app-android/issues/4014) I only verified on locale English (United States).
Since PR https://github.com/corona-warn-app/cwa-app-android/pull/4036 has been merged and CWA 2.10.1 has been released I have opened a new issue https://github.com/corona-warn-app/cwa-app-android/issues/4112 to follow up on this regression.
I will not re-open https://github.com/corona-warn-app/cwa-app-android/issues/4014.
@MikeMcC399 I forwarded your comment into the new internal ticket.
Avoid duplicates
Technical details
Describe the bug
PR https://github.com/corona-warn-app/cwa-app-android/pull/3987 has introduced a regression concerning inconsistent formatting regarding dates of birth.
For example, the date of birth in PersonDetailsFragment_cwa.png in release 2.10 should use the same order of month day year according to the English (United States) locale which is used in the date of sample on the same screen.
Instead of showing the date of birth as 1981/03/20, it should be shown as 03/20/1981.
PersonDetailsFragment_cwa from release/2.10.x
PersonDetailsFragment_cwa from screenshots 2.8 for comparison. In this version the date formats were fixed and did not use the device's locale settings.
Steps to reproduce the issue
set to English (United States)
select "Use locale default"/ disable "Use 24-hour format"
src/androidTest/java/de/rki/coronawarnapp
on emulator/data/data/de.rki.coronawarnapp.test/screenshots
Expected behavior
Dates of birth should be formatted according to the device's locale setting, except in certificates where a field label indicates formatting using YYYY-MM-DD.
Internal Tracking ID: EXPOSUREAPP-9297