search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

Android certificate screenshots have non-certificate QR codes #4021

Closed MikeMcC399 closed 2 years ago

MikeMcC399 commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

Android certificate screenshots shown on https://www.coronawarn.app/en/screenshots/, for instance Android Vaccination Certificate show QR codes which are not EU digital COVID certificate QR codes and which cannot therefore match the details of the screenshot.

image

Steps to reproduce the issue

Generate screenshots

(Set device to small font to capture complete certificate)

  1. In Android Studio
  2. Run TestCertificateDetailsFragmentTest.kt
  3. Run VaccinationDetailsFragmentTest.kt
  4. Run RecoveryCertificateDetailFragmentTest.kt
  5. View > Tools Windows > Device File Explorer
  6. Go to /data/data/de.rki.coronawarnapp.test/screenshots
  7. View screenshots

Scan screenshots

Scan from website for the current CWA version. For future versions scan from generated screenshots (see above).

  1. Using another device, open CWA
  2. Tap scan button
  3. Scan QR Code from TestCertificateDetailsFragment.png
  4. Note error "No Suitable QR Code"
  5. Repeat for VaccinationDetailsFragment_immune.png and for RecoveryCertificateDetailsFragment_recovered.png

Expected behavior

Certificate screenshots should include a QR code which has the correct structure of a EU digital COVID certificate and which matches the details of the certificate displayed, even if the certificate is not signed.

Possible Fix

Modify ScreenshotCertificateTestData.kt to provide correct QR codes instead of using wrong identical dummy data for recovery, test and vaccination certificates.

Internal Tracking-ID: EXPOSUREAPP-9301

mtwalli commented 3 years ago

@MikeMcC399 This is intended, why do you need to display a certificate QrCode ? at the end this is just screenshot for demonstration.

MikeMcC399 commented 3 years ago

@mtwalli

This is intended, why do you need to display a certificate QrCode ? at the end this is just screenshot for demonstration.

That is a valid question. The app should try to achieve consistency between Android and iOS including the screenshots. Seemingly arbitrary differences in the development on the two platforms make providing support and writing FAQ articles more complicated. For instance, the example vaccination certificate screenshot on Android for Max Mustermann is not shown completely whereas on iOS it is for Andrea Schneider and it is shown completely. See https://github.com/corona-warn-app/cwa-app-android/issues/4017.

It is true though that the iOS QR code https://www.coronawarn.app/en/screenshots/#ios_vaccination_certificate can't be read successfully in CWA 2.7 onwards, since it is not a signed certificate. On Android the QR code can't be read because it is just not a certificate at all. So there may not be any practical benefit to adding proper certificate QR codes to Android if they won't be signed and therefore can't be read by current app versions.

I will leave this issue open for comment for the moment. If the Open Source Team considers it not worth fixing then please add the wontfix label and close it.

heinezen commented 3 years ago

@MikeMcC399 I've made a Jira ticket just in case, so the issue doesn't get lost.

Corona-Warn-App Open Source Team

mtwalli commented 2 years ago

Intended behaviour