corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

RKI misspelled in RecoveryCertificate screenshots #4071

Closed MikeMcC399 closed 3 years ago

MikeMcC399 commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

Screenshots

contain the misspelled authority name "Robert-Koch-Institut" in the field "Zertifikataussteller / Certificate Issuer".

Note that the error is not apparent on https://www.coronawarn.app/en/screenshots/#android_recovery_certificate because the screenshots only show the top and bottom of the certificate, not the middle.

Steps to reproduce the issue

In Android Studio

  1. Connect to larger display, such as a tablet
  2. Run RecoveryCertificateDetailFragmentTest.kt
  3. View screenshots in /data/data/de.rki.coronawarnapp.test/screenshots

RecoveryCertificateDetailsFragment_RKI_misspelling

Expected behavior

The authority should be spelled "Robert Koch-Institut" with only one hyphen.

The website https://www.rki.de/DE/Service/Impressum/impressum_node.html is the reference location for the correct spelling of "Robert Koch-Institut" (RKI)

Possible Fix

In https://github.com/corona-warn-app/cwa-app-android/blob/127889b390ef00228a619afb7573c5da724a1a6e/Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/covidcertificate/recovery/ui/RecoveryCertificateDetailFragmentTest.kt#L125 correct spelling to "Robert Koch-Institut".


Internal Tracking ID: EXPOSUREAPP-9452

MikeMcC399 commented 3 years ago

I can submit a PR for this change if you tell me to.

marcauberer commented 3 years ago

@MikeMcC399 feel free to do so 👍🏼

MikeMcC399 commented 3 years ago

PR #4073 submitted.

dsarkar commented 3 years ago

@MikeMcC399 Thanks!

MikeMcC399 commented 3 years ago

PR #4073 is now merged for release/2.10.x.

Since the issue is not visible for regular users we do not need to wait for app release before closing.

Closing now.