search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

Don't show "Letzte Impfung vor 0 Tagen" but "Letzte Impfung heute" (align to iOS) #4122

Closed Ein-Tim closed 3 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

Technical details

Technical details from: https://github.com/Digitaler-Impfnachweis/covpass-android/issues/79

Describe the bug

Currently, the Android app shows "Letzte Impfung vor 0 Tagen" if the user was vaccinated today. The iOS app shows "Letzte Impfung heute". This sounds better and is also what I'd expect based on communication between humans.

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Click on "Zertifikate"
  3. Click on "+ Zertifikat"
  4. Scan a QR code which belongs to an EU digital COVID certificate
  5. Set the device time to the date of the vaccination
  6. See that the text "Letzte Impfung vor 0 Tagen" is shown

Expected behaviour

"Letze Impfung vor 0 Tagen" should be "Letzte Impfung heute" (aligning the behaviour to the iOS app)

Additional context

I opened this issue based on the screenshot I saw in https://github.com/Digitaler-Impfnachweis/covpass-android/issues/79, I wondered if iOS showed the same text and found that only Android shows "Letze Impfung vor 0 Tagen".

Internal Tracking ID: EXPOSUREAPP-9659

dsarkar commented 3 years ago

@Ein-Tim Thanks. Internal Tracking ID: EXPOSUREAPP-9659

Corona-Warn-App Open Source Team

jkrwdf commented 3 years ago

Looking at the screenshot from CWA with both eyes, we can even see that it uses a lower-case letter L in the beginning of this sentence, which at this location is felt wrong and should be an upper-case L.

Ein-Tim commented 3 years ago

@jkrwdf

I suggest you open a new issue in the documentation repository for this, as iOS also shows "letzte Impfung" with a lower-case "l" instead of "L".

MikeMcC399 commented 3 years ago

@Ein-Tim

There was a similar change done for the immunity count-down to show tomorrow instead of "0 days" in 2.4. So there is a good precedent for making this change. See https://github.com/corona-warn-app/cwa-app-android/pull/3575.

"Letze" is misspelled in the title of this issue. Maybe you'd like to correct it?

Ein-Tim commented 3 years ago

4145 Implements this.

Ein-Tim commented 3 years ago

I can confirm that this issue has been fixed in version 2.12.

Here's a screenshot:

Screenshot_20210917_173620

Closing this issue as fixed.

dsarkar commented 3 years ago

@Ein-Tim Thanks for the feedback!