Reference to file in QR scan from camera error message

MikeMcC399 commented 3 years ago

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[ ] Bug is not already reported in another issue The bug was already mentioned in https://github.com/corona-warn-app/cwa-wishlist/issues/343#issuecomment-925622491 and was not actioned from there. Note that the typo (canned) is reported in https://github.com/corona-warn-app/cwa-app-android/issues/4155.

Technical details

Device name: Samsung Galaxy A5 (2017) SM-A520F
Android version: 8.0.0
First reported in App version: 2.11.0-RC3
Confirmed also present in App version: 2.11.2

Describe the bug

When a user tries to scan an incompatible QR code via the device's camera, the error message says to select a file (rather than another image).

The text comes from qr_code_no_suitable_qr_code_body

"The QR code cannot be canned (sic) by the Corona-Warn-App. Please select a file with a suitable QR code."

Steps to reproduce the issue

Set locale to English (United States)
Tap "Certificates" tab (tap "CONTINUE" if necessary)
Tap "+ CERTIFICATE" and scan any non-CWA code such as
Note the pop-up message which refers to "file"

No_suitable_QR_code_EN_a_file

Expected behavior

The error message should not refer to a file if a QR code was scanned using the camera.

Possible Fix

The string qr_code_no_suitable_qr_code_body is being used. "The QR code cannot be canned (sic) by the Corona-Warn-App. Please select a file with a suitable QR code."

Either this string should be made neutral concerning the source of the QR code (camera or file), or the error message should be made dependent on the source of the incorrect QR code, i.e. different message depending on whether scan from camera or scan from file was used.

Internal Tracking-ID: EXPOSUREAPP-9763

Ein-Tim commented 2 years ago

PR: https://github.com/corona-warn-app/cwa-app-android/pull/4185

MikeMcC399 commented 2 years ago

The message in German in release/2.12.x is now "Der QR-Code kann nicht in der Corona-Warn-App gescannt werden. Bitte wählen Sie einen geeigneten QR-Code."

The English language message body (qr_code_no_suitable_qr_code_body) is still "The QR code cannot be scanned by the Corona-Warn-App. Please select a file with a suitable QR code." so presumably the translation has not yet been done and integrated.

MikeMcC399 commented 2 years ago

English text not yet fixed in tag/v2.12.0-RC1.

MikeMcC399 commented 2 years ago

This issue is resolved in tag/v2.12.0-RC2 through PR https://github.com/corona-warn-app/cwa-app-android/pull/4212.

https://github.com/corona-warn-app/cwa-app-android/blob/5af220165c63a398d921da77a3894a3cdfe89082/Corona-Warn-App/src/main/res/values/strings.xml#L939-L940

No suitable QR code

MikeMcC399 commented 2 years ago

This issue is verified as resolved in the 2.12.1 release.

Steps to verify

Set locale to English (United States)
Tap "Certificates" tab (tap "CONTINUE" if necessary)
Tap "Scan" button in the lower navigation bar and scan any non-CWA code such as
Note the pop-up message which now generically says "Please select a suitable QR code." and no longer refers to "file"

No suitable QR code

dsarkar commented 2 years ago

Good morning @MikeMcC399 , thanks for the feedback!

corona-warn-app / cwa-app-android