search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

Stack trace after scanning incompatible QR code #4158

Closed MikeMcC399 closed 3 years ago

MikeMcC399 commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

When a user tries to scan an incompatible QR code via the device's camera, the error message DETAILS selection outputs a stack trace.

Steps to reproduce the issue

  1. Set locale to English (United States)
  2. Tap "Certificates" tab (tap "CONTINUE" if necessary)
  3. Tap "+ CERTIFICATE" and scan any non-CWA code such as

    QR Code DE12345678
  4. A pop-up message appears

No_suitable_QR_code_EN

  1. Tap on "DETAILS"
  2. Note stack trace

Scan_stack_trace

Expected behavior

Since this is a user error, and a programming error is not likely, the error message should not output a stack trace.

Possible Fix

Either:

  1. Connect to an existing or new FAQ article regarding compatible QR codes for the app or
  2. Output the contents of the QR code in readable format for technical troubleshooting

Internal Tracking-ID: EXPOSUREAPP-9762

heinezen commented 3 years ago

@MikeMcC399 Thanks for the report. We've created a Jira ticket for the issue.

Corona-Warn-App Open Source Team

MikeMcC399 commented 3 years ago

This issue (https://github.com/corona-warn-app/cwa-app-android/issues/4158 - Internal Tracking-ID: EXPOSUREAPP-9762) seems to have been fixed in https://github.com/corona-warn-app/cwa-app-android/pull/4171 "Uqs error handling / dialog clenaup (EXPOSUREAPP-9777)" which was included in tag/v2.12.0-RC0.

Testing in tag/v2.12.0-RC2 there is no longer a "DETAILS" option and therefore no stack trace, which therefore resolves the issue.

No suitable QR code

MikeMcC399 commented 3 years ago

@dsarkar Could you check to see if the Fix 2.12 label should be re-applied?

MikeMcC399 commented 3 years ago

This issue is verified as resolved in the 2.12.1 release. There is no longer a "DETAILS" option and therefore no stack trace.

Steps to verify

  1. Set locale to English (United States)
  2. Tap "Certificates" tab (tap "CONTINUE" if necessary)
  3. Tap "Scan" button in the lower navigation bar and scan any non-CWA code such as

    QR Code DE12345678
  4. Note the pop-up message contains only the "OK" exit option. No stack trace is available or shown

No suitable QR code

dsarkar commented 3 years ago

Good morning @MikeMcC399 , thanks for the feedback!