UQS pop up is shown on top of other screens

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

2.44k stars 495 forks source link

UQS pop up is shown on top of other screens #4400

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: Huawei P Smart 2019
Android version: 10
App version: 2.13.3

Describe the bug

The UQS pop up is shown on top of other screens, here are some examples:

Steps to reproduce the issue

Delete and reinstall the app
Do not dismiss the pop up
Create a QR code on https://www.coronawarn.app/en/eventregistration/ and scan it with an external QR code scanner
Enter the app following the link
See the issue which is shown in the first screenshot above
Try the same with RA test result QR codes

Expected behaviour

The pop up should not be shown if the app is not displaying the normal screens ("Status", "Certificates", "Check-in" or "Jounal").

Internal Tracking ID: EXPOSUREAPP-10623

dsarkar commented 2 years ago

Good morning @Ein-Tim, thanks for reporting: Internal Tracking ID: EXPOSUREAPP-10623

fynngodau commented 2 years ago

Thanks for reporting, Tim!

dsarkar commented 2 years ago

FYI PR https://github.com/corona-warn-app/cwa-app-android/pull/4607

MikeMcC399 commented 2 years ago

@Ein-Tim

Did you look at this again?

Regarding your steps to reproduce: with the 2.17.2 version I did not see the pop-up appear after resetting the app, only after reinstalling.

Ein-Tim commented 2 years ago

@MikeMcC399

I currently don't have access to the Android device anymore, thus I can't check, sorry.

Maybe @fynngodau would like to test this again?

MikeMcC399 commented 2 years ago

@Ein-Tim I tried on 2.18.1 and again, the pop-up does not appear after resetting the app. I simulated a re-install by clearing the app's data and I then scanned an event code. This took me to the onboarding screen "LET'S GET STARTED". After completing onboarding, the QR Code Scanner pop-up was shown on top of the Check In screen.

This means that the issue is not resolved.

It may be that this is considered acceptable behaviour though. Normally the pop-up would be shown once only after installation. It would then be dismissed by the user and never shown again.

MikeMcC399 commented 2 years ago

I suggested in the new issue https://github.com/corona-warn-app/cwa-app-android/issues/4940 to remove the UQS pop-up. I don't think that this pop-up is needed any more. It was useful, when version 2.12 was released, since previously there were different places to scan QR codes depending on their contents. The Universal QR code scanner allows all CWA-related QR codes to be scanned from one button. Version 2.12 was released in October 2021 and by this time users should be accustomed to the functionality and should therefore not need a special one-time pop-up to remind them.

MikeMcC399 commented 2 years ago

@dsarkar

Either this issue should be closed (and a new issue opened to cover the remaining issue) or the label https://github.com/corona-warn-app/cwa-app-android/labels/Fix%202%2E16 should be removed.

dsarkar commented 2 years ago

@Ein-Tim see comment https://github.com/corona-warn-app/cwa-app-android/issues/4400#issuecomment-1117104473. Following @MikeMcC399's suggestion, do you want to close this issue since the remaining issue is covered in https://github.com/corona-warn-app/cwa-app-android/issues/4940?

Ein-Tim commented 2 years ago

This issue was never fixed, especially problematic is when the pop up is shown on top of screens although the UQS icon is not visible.

I'm unsure if I should close this issue although it was not addressed. I think it should stay open until either @MikeMcC399's enhancement request us implemented or the bug fixed.

MikeMcC399 commented 2 years ago

@Ein-Tim

If you want to leave this issue open, then I suggest you update the steps to reproduce, because in current versions, resetting the app does not cause the pop-up to re-appear.

Ein-Tim commented 2 years ago

Done @MikeMcC399

MikeMcC399 commented 2 years ago

@Ein-Tim

Thanks for updating the steps to reproduce. The app is unusable unless the "QR Code Scanner" pop-up is dismissed, so it is quite intrusive. Dismissing the pop-up is however quite a simple operation (tap on "X").

If this issue is to stay open, then the labels https://github.com/corona-warn-app/cwa-app-android/labels/Fix%202%2E16 and https://github.com/corona-warn-app/cwa-app-android/labels/ready-to-close should be removed.

Ein-Tim commented 2 years ago

@dsarkar Please remove the labels as @MikeMcC399 suggested above.

svengabr commented 2 years ago

I did re-open the closed Jira ticket EXPOSUREAPP-10623

dsarkar commented 2 years ago

FYI PR https://github.com/corona-warn-app/cwa-app-android/pull/5366

Ein-Tim commented 2 years ago

@dsarkar Are you sure that this PR prevents the showing of the UQS tool tip on top of other screens? I'm only seeing changes in regard to the tap area in the PR.

dsarkar commented 2 years ago

@Ein-Tim You are right. PR is still interesting here since a related topic.

MikeMcC399 commented 2 years ago

@dsarkar / @Ein-Tim

I have commented in https://github.com/corona-warn-app/cwa-app-android/pull/5366#issuecomment-1190193726 and suggested delaying the display of the pop-up. That would also fit in with stopping the pop-up displaying on screens where no scan button is displayed.

MikeMcC399 commented 2 years ago

@Ein-Tim

PR https://github.com/corona-warn-app/cwa-app-android/pull/5366 has been changed to stop the UQS tooltip appearing on a new install, so your steps to reproduce in the OP will no longer show the issue.

MikeMcC399 commented 2 years ago

@Ein-Tim

You might like to try out release/2.26.x since the reworked PR #5366 has been merged. Perhaps your expectations are now met in order to resolve this issue?

Ein-Tim commented 2 years ago

@MikeMcC399

I currently don't use Android Studio, but as I wanted to begin with it anyways, I will probably take this chance and take a look at it as soon as I have time.

mtwalli commented 2 years ago

@Ein-Tim I checked it this in 2.26 and can't reproduce, probably because of the changes made by https://github.com/corona-warn-app/cwa-app-android/pull/5366.

Ein-Tim commented 2 years ago

I currently don't have access to my Android device, but as soon as I get back home I'll test if this bug is fixed successfully with version 2.26.

MikeMcC399 commented 2 years ago

@Ein-Tim

If you delete and re-install the app, then no UQS pop-up is shown with CWA Android 2.26.
I already closed the related issue https://github.com/corona-warn-app/cwa-app-android/issues/4940.

Ein-Tim commented 2 years ago

@MikeMcC399 Okay, thanks! This issue seems fixed so I'm closing it now.