search

corona-warn-app / cwa-app-android

Native Android app using the Apple/Google exposure notification API. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
2.44k stars 495 forks source link

Exposure Logging is in false "active" state when Location is turned off #881

Closed kbobrowski closed 4 years ago

kbobrowski commented 4 years ago

Describe the bug

After switching off Location app still displays that Exposure Logging is active, when in fact it is not. There is a notification displayed from Play Services to turn Location back on, but it can be dismissed (even accidentally, by dismissing all notifications), and user stays in a state with exposure logging not working, false "active" status displayed in the app, and no clue how to turn it back on.

Expected behaviour

App should always display correctly whether exposure logging is active, and guide user to turn Location back on if this is the reason for exposure logging not working. This is already handled correctly for the case when Bluetooth is off.

Steps to reproduce the issue

  1. download the app
  2. agree to exposure logging
  3. turn location off
  4. dismiss all notifications
  5. check if you are in a false state of "active" exposure logging with no clue how to turn it back on

Technical details

Android 10

Possible Fix

I'd suggest to take a look how Immuni app from Italy handles this. If using "Location" word is not desired here app can simply display "Service inactive", and a button to activate it which brings up "Turn on COVID-19 Exposure Notifications?" prompt again and leaves it up to Exposure Notifications framework to handle turning on all required services.

Internal Tracking ID: EXPOSUREAPP-1618

btreut commented 4 years ago

@aurisnoctis

sorry for the late answer ...

On my German Android version 6.0.1 it is: Android Einstellungen > Standort > Modus > Nur GPS.

on my German Android 8.0.0 (Samsung Galaxy S7) the only hint for "Only GPS" is far down in tree:

Android Einstellungen > Verbindungen > Standort > Suchmethode > Nur Telefon

and on all higher levels it is called "Nur Telefon" which I find a bit misleading, but that is Googles fault.

screenshot

BTW: Most things work nicely with GPS only ("Nur Telefon"). Sometimes Google Maps switches back to "Hohe Genauigkeit". I am not sure if it does that without asking for my permission to use the Standort or if I occasionally hit "OK" when being asked "Zum Fortfahren Standortermittlung für dein Gerät über die Standortdienste von Google aktivieren". When hitting "NEIN DANKE" at this question and GPS only ("Nur Telefon") is active, Maps still localizes me correctly. Android does not show the Balloon icon in the status line at top (as can be seen in the screensot above). But dragging down the Settings menu by wiping down from the top end reveals an active balloon:

screenshot
aurisnoctis commented 4 years ago

Update to https://github.com/corona-warn-app/cwa-app-android/issues/881#issuecomment-648214790

Google seems to have fixed wrong ENF-Notifications about missing location and bluetooth as of ENF version 15202902003 (on Samsung S5 with stock Android 6.0.1), so I closed https://github.com/google/exposure-notifications-android/issues/35.

At least this helps to now correctly inform people that location has to be turned on. Happy that the CWA team is working on it as well.

kbobrowski commented 4 years ago

Fixed for me (v1.2.0) - when switching off location, exposure logging is no longer displayed as "active" in the app