Upgrade github actions with new node version

corona-warn-app / cwa-app-ccl

Common Covid Logic (CCL) for Android and iOS

Apache License 2.0

7 stars 4 forks source link

Upgrade github actions with new node version #127

Closed brianebeling closed 1 year ago

brianebeling commented 2 years ago

Fixes #126

This PR changes all the actions, however, it doesn't test all actions. The pipeline for PR Validation / build (pull_request) triggers on PR and worked successfully.

I'd strongly recommend dry running the other pipelines as well, prior to merging.

Internal Tracking ID: EXPOSUREAPP-14302

brianebeling commented 2 years ago

Seems to work: https://github.com/corona-warn-app/cwa-app-ccl/actions/runs/3419483556/jobs/5693061213

brianebeling commented 2 years ago

I just noticed some dependencies might need additional updating, but I'm not entirely sure because of the limited test capability of this issue, without creating a local environment of sorts (private repo, some tool, ...)

Namely: richardsimko/update-tag and softprops/action-gh-release

MikeMcC399 commented 2 years ago

@brianebeling

richardsimko/update-tag looks like it was fixed in v1.0.6 so there should be no need for a workflow update. @v1 will refer to the latest v1 version with the fix.

MikeMcC399 commented 1 year ago

softprops/action-gh-release has been fixed in https://github.com/softprops/action-gh-release/releases/tag/v0.1.15. Since there was no change to the major version it should not require any change to the CCL workflows to use the updated version.

MikeMcC399 commented 1 year ago

@mlenkeit

Since there seems to be a new CCL release planned I would suggest merging this PR.

The same action updates have been made in other repositories, e.g. cwa-website with positive results and no side-effects.

mlenkeit commented 1 year ago

@MikeMcC399 yes, I'll include these changes.