search

corona-warn-app / cwa-app-ccl

Common Covid Logic (CCL) for Android and iOS
Apache License 2.0
7 stars 4 forks source link

Chore: reproduce EXPOSUREAPP-12543 regression #96

Closed mlenkeit closed 2 years ago

mlenkeit commented 2 years ago

This is a test PR to verify if the new end-to-end tests introduced by #95 would have detected the regression from #91.

The changes are a bit messy because multiple branches were merged, but the PR itself is anyway not meant to be merged.

mlenkeit commented 2 years ago

At https://github.com/corona-warn-app/cwa-app-ccl/pull/96/commits/0045fa4d3122ca6162a13c8516edaa303652d511, the dob-logic from #91 was included in this branch, but the PR validation runs a merge commit on the target branch (i.e. release/3.2.x) on which the respective revert commit already existed. So we need to update this branch with release/3.2.x and then ensure that the dob-logic is back in (i.e. revert the revert-commit).

mlenkeit commented 2 years ago

At https://github.com/corona-warn-app/cwa-app-ccl/pull/96/commits/1f257f4221929bfa8781ab5ed44cdc99fe4990a4, we see the CCL tests on iOS failing as a side-effect of the changes from #91.

image

When we revert the changes (like in #95), then the tests should pass again...

mlenkeit commented 2 years ago

... at https://github.com/corona-warn-app/cwa-app-ccl/pull/96/commits/6d4d0d873caf6f06f7d7d959be9126fcfa0ba67d, all tests pass:

image

This should be good enough of a proof that the new end-to-end tests introduced by #95 would have detected the regression from #91.

I will close the PR.