search

corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
1.68k stars 286 forks source link

Highlight effect is shown on areas it shouldn't be shown #2245

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

This highlight effect is shown on a) some empty areas b) areas that don't do anything if clicked on

Screen recording from a) https://user-images.githubusercontent.com/67682506/111690871-01807100-882e-11eb-986d-ec5db1a1e2c0.mp4

and

Screen recording from b) - Case 1 https://user-images.githubusercontent.com/67682506/111690884-03e2cb00-882e-11eb-9ff9-569a881a79a0.mp4
Screen recording from b) - Case 2 https://user-images.githubusercontent.com/67682506/112021738-e36a8780-8b31-11eb-9e99-870c801dd7b6.mp4

It should only be shown on fields that will do something (like the "Share the Corona-Warn-App" section).

Steps to reproduce the issue

a)

  1. Open the contact diary
  2. Click on the 3 dots in the top right corner
  3. Click on information
  4. Click on the empty space between the points
  5. See highlight effect

and

b)

Case 1:

  1. Open the "Have you been tested?" box
  2. Click on "No TAN yet"
  3. Tap on the text in the section "How this works"
  4. See highlight effect

Case 2:

  1. Open the "Overview"
  2. Tap on "Increased Risk", "Low Risk"
  3. See highlight effect.

Expected behaviour

Highlight effect only shown on areas that do something (like open a menu, etc.).

Additional context

Affected screens (that I found) are:

Related Issue

Internal Tracking ID: EXPOSUREAPP-5896

dsarkar commented 3 years ago

Internal Tracking ID: EXPOSUREAPP-5896

Ein-Tim commented 3 years ago

FYI @dsarkar I updated the op with one more place I found this bug

dsarkar commented 3 years ago

@Ein-Tim OK, Thanks. Will add the additional information to the internal ticket.

Ein-Tim commented 3 years ago

And one more case:

dsarkar commented 3 years ago

@Ein-Tim ok, added to ticket.

Ein-Tim commented 3 years ago

All cases mentioned in the OP have been fixed in version 2.3, but

Case 2:

  1. Open the "Overview"
  2. Tap on "Increased Risk", "Low Risk"
  3. See highlight effect.

@hansemann I assume this is a quick fix. Would you like to quickly fix this too? This would be marvelous!

ndegendogo commented 2 years ago

@Ein-Tim what exactly is missing here?

Ein-Tim commented 2 years ago

@ndegendogo

Nothing missing, there's something too much here 😉

There should be no highlight effect when clicking in the Overview on "Increased Risk" or "Low Risk".

See https://github.com/corona-warn-app/cwa-app-ios/issues/2245#issuecomment-857088356

ndegendogo commented 2 years ago

ah - found it 😅

ndegendogo commented 2 years ago

@dsarkar @heinezen I have submitted PR #3790 with the fix for the missing part. Please apply the labels - thanks.

Ein-Tim commented 2 years ago

@ndegendogo

Thank you for this PR too! 👍

ndegendogo commented 2 years ago

@Ein-Tim could you please test it and confirm if it is fixed now? Thanks!

Ein-Tim commented 2 years ago

@ndegendogo

Thanks for reminding me! Yes, this was fixed in version 2.14!

Closing.

dsarkar commented 2 years ago

@ndegendogo @Ein-Tim Thanks for CONFIRM. internal ticket set accordingly.