Remove option to press "Do Not Allow" in the onboarding screen "Receive warnings and identify risks"

corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

1.68k stars 284 forks source link

Remove option to press "Do Not Allow" in the onboarding screen "Receive warnings and identify risks" #2286

Closed Ein-Tim closed 3 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

[X] This issue has not already been raised before
[X] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

During the onboarding, the iOS App gives the user the choice to decline the receiving of pop up notifications (like Deadman notifications, change of the risk status, availability of the test result).

Here's a screenshot (from www.coronawarn.app/en/screenshots/):

Suggested Enhancement

Remove the option to press "Do Not Allow" in the app. After clicking on "Next" iOS will prompt this to the user:

There the user can decide wether he want's to activate notifications or not. This is already done under Android (see this screenshot from from www.coronawarn.app/en/screenshots/).

Expected Benefits

Less users accidentally clicking on "Do Not Activate" (see https://github.com/corona-warn-app/cwa-wishlist/issues/404) and the user doesn't have to allow the same thing twice.

Internal Tracking ID: EXPOSUREAPP-6001

dsarkar commented 3 years ago

@Ein-Tim Thanks. I can't reproduce this. I do not get the pop-up. When you do the onboarding what are the notification settings in the OS. I assume off, but even then I can trigger this pop-up notification. Also, I think this notification is from the OS not CWA.

Ein-Tim commented 3 years ago

@dsarkar

You would have to deinstall the app and reinstall it to trigger this pop up, because only then the consent is revoked by iOS.

Yes this pop us is from iOS, but the current user experience is:

CWA in-app asks if it can send you notifications
User clicks "Next"
iOS pop up asks again wether the user wants to allow notifications from CWA. There you can again click "Allow" or "Don't allow"
User clicks on "Allow" and can continue.

Better would be:

CWA says it want to send you notifications
User clicks on "Next"
iOS asks for permission, there the user can choose what he want

dsarkar commented 3 years ago

@Ein-Tim Actually, trying to re-produce this, I might have found a related bug. Not sure yet if this is OS bug or CWA.

reset in-app (not re-install) In OS settings > Corona-Warn > Mitteilungen > set "Aus" Do Onboarding > choose "Weiter" in "Warnungen erhalten" Check iOS settings > Corona-Warn > Mitteilungen > is still set "Aus"

Any idea how to trigger a "Mitteilung" / notification, in order to test?

Ein-Tim commented 3 years ago

@dsarkar

Do Onboarding > choose "Weiter" in "Warnungen erhalten" Check iOS settings > Corona-Warn > Mitteilungen > is still set "Aus"

This is a iOS bug I think. iOS didn't ask again for permission to send notifications or?

Any idea how to trigger a "Mitteilung" / notification, in order to test?

Only deadman, turn off bluetooth for 36h and wait for the notification.

dsarkar commented 3 years ago

@Ein-Tim

This is a iOS bug I think. iOS didn't ask again for permission to send notifications or?

Nope, no pop-up. I will try with a full re-install.

Ein-Tim commented 3 years ago

@dsarkar

Thanks, I think it should be as intended after reinstall.

Ein-Tim commented 3 years ago

@dsarkar

I see you opened #2288. Could you please mirror this to JIRA? Thank you very much and have a nice Sunday.

dsarkar commented 3 years ago

@Ein-Tim Internal Tracking ID: EXPOSUREAPP-6001

mrlnc commented 3 years ago

@dsarkar Gibt es hier ein Update vom CWA-Team?

Den Dialog gibt es in der Form seit Dezember 2020, was potentiell 1.6 Millionen neuen Nutzer:innen entspricht.

Soweit ich verstehe, ist die Warnfunktion per Notification eine zentrale Funktion. Als Vergleich SwissCovid:

Den Button zu entfernen ist praktisch nur eine Zeile, aber das ist natürlich nur ein kleiner Teil des eigentlichen Problems (bestehende Nutzer:innen ohne Warnungen). https://github.com/mrlnc/cwa-app-ios/commit/864b0c0a02add8f135afef5f37394ef8721b2a48

Ein-Tim commented 3 years ago

@mrlnc

May I ask you to open a PR for the changes you made?

You can tag this issue that'll get fixed and also refer to Android, which is already missing the "Do Not Activate" button.

I can also confirm that these changes are working (tested on an Emulator).

heinezen commented 3 years ago

@mrlnc Nothing new on this from our side about this, sorry.

Corona-Warn-App Open Source Team

mrlnc commented 3 years ago

My pull request https://github.com/corona-warn-app/cwa-app-ios/pull/2924 was closed, was this issue resolved? @marcussc

The issue still appears in the app store version.

marcussc commented 3 years ago

@mrlnc sorry GitHub automatically closed the Issue since the target branch has been deleted. Somehow I am not able to change the target branch nor reopen it. Are you able to do so?

mrlnc commented 3 years ago

Sorry, I missed that. Is the PR any helpful? I'd consider to re-submit then. But it seems that the onboarding UX is frozen anyways.

marcussc commented 3 years ago

@mrlnc sorry for the slight delay with my answer. Yes, it would be very nice if you could reopen your PR against the release/2.8.x branch

Ein-Tim commented 3 years ago

PR: #3500

Ein-Tim commented 3 years ago

I will confirm the fix via an Emulator by todays evening.

Ein-Tim commented 3 years ago

I can confirm that the button has been removed with version 2.11.

Closing this issue as implemented.

dsarkar commented 3 years ago

@Ein-Tim Thanks for confirming. Forwarded to internal ticket. Good night!