search

corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
1.68k stars 284 forks source link

Unnecessary free space on top of "Transnational Exposure Logging" screen #2414

Closed Ein-Tim closed 3 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

There's an unnecessary free space above of the illustration in the "Transnational Exposure Logging" screen. This looks very strange in dark mode, because the dark color from the illustration isn't the same as the dark color of the background.

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Click on "Exposure Logging Active/Stopped"
  3. Click on "Transnational Exposure Logging"
  4. See the free space above of the illustration

Expected behaviour

No free space.

Screenshots

Screenshots iPhone 6s: Light Mode: Dark Mode: iPhone XR: Light Mode: Dark Mode:

Internal Tracking ID: EXPOSUREAPP-6354

dsarkar commented 3 years ago

@Ein-Tim Thanks, Internal Tracking ID: EXPOSUREAPP-6354.

ndegendogo commented 3 years ago

@dsarkar @heinezen is anybody working on this?

I volunteer - I have a suspicion on the root cause

ndegendogo commented 3 years ago

The navigation item for this view controller is setup with a large title, although the title is empty. Hence the extra wide navigation bar.

However, I have the suspicion that this was implemented intentional. We would get a transition from normal to Large titles, and this animation would look ugly in the current implementation, and was avoided. For this reason I guess this should be not fixed before #3372.

ndegendogo commented 3 years ago

It is not an issue on iPhone 6 with iOS 12.5.3 (tested on true device). It is an issue on iPhone SE with iOS 13+ (small screen, tested with simulator).

ndegendogo commented 3 years ago

PR #3442.

Ein-Tim commented 3 years ago

Thank you @ndegendogo!

ndegendogo commented 3 years ago

@dsarkar @heinezen could you please label this PR so that the devs are not too confused? 😅

Thanks

Ein-Tim commented 3 years ago

I can confirm that this has been fixed in version 2.10 (by @ndegendogo).

One small thing, in darkmode, there is still a visible (unnecessary) free space:

How it is now How it should be

Maybe something for you @ndegendogo? But that's only a very minor thing.

ndegendogo commented 3 years ago

One small thing, in darkmode, there is still a visible (unnecessary) free space:

@Ein-Tim only in dark mode, really? This seems strange ...

jucktnich commented 3 years ago

I cannot confirm a fix for iPhone SE 1

ndegendogo commented 3 years ago

I cannot confirm a fix for iPhone SE 1

@jucktnich @Ein-Tim what do you propose then? Reopen this, or a new ticket?

Ein-Tim commented 3 years ago

@ndegendogo It's only visible in dark mode, sorry.

You can look into this, without an open issue. But as said, this is only a minor thing and isn't worth a new ticket (at the moment) IHMO.

ndegendogo commented 3 years ago

One small thing, in darkmode, there is still a visible (unnecessary) free space:

@Ein-Tim I have just checked on the simulator. The layout in dark mode and in light mode match exactly (you can watch this if you toggle the appearance in the simulator menu). Only in light mode, the color tone of the background of the artwork and of the table are the same (both RGB = 255/255/255), whereas in dark mode, the color tones are different (background of artwork RGB = 0/0/0, background of table RGB = 30/30/31).

At the moment I can only assume this is intentional, so I won't change it. But this could be a question to the designers of the development team.

ndegendogo commented 3 years ago

@jucktnich may I ask for the iOS version of your SE 1? Is it a 12.5?

ndegendogo commented 3 years ago

@Ein-Tim actually, the runtime complains about a conflict in the layout. So maybe this narrow dark-grey band between navigation bar and artwork is indeed an artefact of this layout conflict?

Ein-Tim commented 3 years ago

@ndegendogo

Yeah, could be. What would speak against to remove the narrow grey band over the illustration?

jucktnich commented 3 years ago

@ndegendogo I'm on iOS 15. But I don't think, that the space is bad for the UX, since it's not as big as it was.

ndegendogo commented 3 years ago

What would speak against to remove the narrow grey band over the illustration?

You are right. It looks weird in dark mode. And a PR would be the easiest way to get an opinion of the designers.

So the next step would be to find out how to get rid of it - I'll try

ndegendogo commented 3 years ago

I'm on iOS 15

@jucktnich this is actually good news. I don't yet know if / how it is possible to test the cwa user interface with a 12.4 simulator, and Apple never released a simulator for 12.5. So I'll ignore the iOS version (for the moment) and focus on trying to get a simulator with the screen size of SE 1 .... 🤪

Ein-Tim commented 3 years ago

@ndegendogo

So the next step would be to find out how to get rid of it - I'll try

Thank you! 👍

ndegendogo commented 3 years ago

The image of the European map is enclosed in a table cell. This cell has full screen width, but a hard-coded height. The image is scaled without distortion to fit inside this cell. But the cell is a bit too high, so the background of the cell is visible. Most of the images of cwa have a background color of RGB = 30/30/31 in dark mode, which blends perfectly with the table background. Only this image has a deep black background color of RGB = 0/0/0.

A solution would be to specify no explicit cell height, then the dark grey band disappears.

(The alternate solution would be to give this cell a background color of RGB = 0/0/0 instead of RGB = 30/30/31, but I don't know how to configure that.)

Ein-Tim commented 3 years ago

I am happy to confirm that this issue now has been finally fixed in version 2.12.

Here's a screenshot:

Closing this issue as fixed in version 2.12.

dsarkar commented 3 years ago

Good morning @ndegendogo, @jucktnich, @Ein-Tim and community! Thanks for contributing here! Best wishes, DS

Corona-Warn-App Open Source Team