corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
1.68k stars 284 forks source link

UI: Empty space at the bottom of the "My Check-Ins" screen #3332

Closed Ein-Tim closed 3 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

There's this unnecessary free space on the bottom of the "My Check-Ins" screen, if you've got more than 4 Check-Ins (in my case). The free space cuts off the last Check-In box and thus I have to scroll down if I want to see the whole Check-In box.

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Make sure you have enough Check-Ins so that they don't fit on one page anymore
  3. See that there's an empty space at the bottom of the screen

Expected behaviour

No empty space.


Internal Tracking-ID: EXPOSUREAPP-9083

ndegendogo commented 3 years ago

The empty space is related to the safe area of a footer view with the button "Remove All". This button is invisible till the user selects the menu "Edit". However, the safe area of this footer view is always active.

dsarkar commented 3 years ago

@ndegendogo Thanks. Information is forwarded into internal ticket.

ndegendogo commented 3 years ago

I have submitted PR #3628 with a fix.

@dsarkar @heinezen please apply the labels. Thanks!

dsarkar commented 3 years ago

@ndegendogo Thanks.

Ein-Tim commented 3 years ago

This issue has been fixed in version 2.12.

Here's a screenshot:

As you can see, there's no longer an empty space on the bottom, above of the tab bar.

Thanks for fixing this @ndegendogo!

Closing this issue as fixed in version 2.12.

dsarkar commented 3 years ago

Good morning @ndegendogo , @Ein-Tim and community! Thanks for contributing here! Best wishes, DS


Corona-Warn-App Open Source Team