corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
1.68k stars 284 forks source link

UI: Empty space at the bottom of the "My QR Codes" screen #3408

Closed Ein-Tim closed 3 years ago

Ein-Tim commented 3 years ago

Avoid duplicates

Technical details

Describe the bug

There's this unnecessary free space on the bottom of the "My QR Codes" screen, if you've got more than 3 QR Codes (in my case). The free space cuts off the 3rd QR-Code box.

Steps to reproduce the issue

  1. Open the Corona-Warn-App
  2. Scroll down to the "Planning an event?" box
  3. Click on "Create QR Code"
  4. Click on "Create QR Code" to create some QR codes
  5. See the free space

Expected behaviour

No empty space.


Related issue


Internal Tracking ID: EXPOSUREAPP-9750

ndegendogo commented 3 years ago

Same root cause as #3332

dsarkar commented 3 years ago

@ndegendogo Thanks, forwarded!

dsarkar commented 3 years ago

Internal Tracking ID: EXPOSUREAPP-9750

ndegendogo commented 3 years ago

@dsarkar please ask the devs if they are planning to work on this. Else I would volunteer to try ... 😎

heinezen commented 3 years ago

@ndegendogo There is nobody assigned yet, so you can try :)


Corona-Warn-App Open Source Team

ndegendogo commented 3 years ago

I have submitted PR #3628 with a fix.

@dsarkar @heinezen please apply the labels. Thanks!

Ein-Tim commented 3 years ago

This has been fixed in version 2.12.

Here's a screenshot:

As you can see, there is no longer a free space at the bottom above the tab bar.

Thank you for fixing this @ndegendogo!

Closing this issue as fixed in version 2.12.

dsarkar commented 3 years ago

Good morning @ndegendogo , @Ein-Tim and community! Thanks for contributing here! Best wishes, DS


Corona-Warn-App Open Source Team