corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
1.68k stars 286 forks source link

"Warn On Behalf" screen has lost its title (regression) #3649

Closed ndegendogo closed 2 years ago

ndegendogo commented 2 years ago

Avoid duplicates

Technical details

Describe the bug

The screen "Warn on behalf" has no title. This is a regression.

Steps to reproduce the issue

Expected behaviour

a title should be shown

Possible Fix

Root cause is the order of setting up the title and creating the navigation items. This is indeed tricky...

Additional context

Screenshot see below. Again, a side effect of the refactoring #3474 👹 I have yet to confirm if this issue is still present with the latest source.

Suspecting that also ExposureSubmissionCheckinsViewController is affected.


Internal Tracking ID: EXPOSUREAPP-9826

dsarkar commented 2 years ago

Good morning @ndegendogo, thanks for reporting. Internal Tracking ID: EXPOSUREAPP-9826

ndegendogo commented 2 years ago

@dsarkar please ask the devs. I can offer a PR, but not before this evening (I am going to work now 😅) Maybe the devs are faster; maybe they even manage to get a fix into the 2.12; but maybe they are busy with higher-priority tasks.

ndegendogo commented 2 years ago

1BE8A904-D85F-4132-A346-5AA56CDE08C9

dsarkar commented 2 years ago

@ndegendogo ok, stand by, I informed dev team.

dsarkar commented 2 years ago

@ndegendogo what about this? https://github.com/corona-warn-app/cwa-app-ios/issues/3474#issuecomment-919751130

ndegendogo commented 2 years ago

@dsarkar you are right. I just got the 2.11 release and can confirm that it is fixed, so I can close this ticket.

dsarkar commented 2 years ago

@ndegendogo Thanks!