corona-warn-app / cwa-app-ios

Native iOS app using the exposure notification framework from Apple. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
1.68k stars 285 forks source link

Validity of Certificate test should always have the current date and time pre-filled #4825

Closed skra72 closed 1 year ago

skra72 commented 2 years ago

Avoid duplicates

Current Implementation

Currently when opening the 'Validity of Certificate' screen the values under 'Check for' are pre-filled with the data the last time such a test was done. Actually this means that most of the time the pre-filled date is in the past.

Suggested Enhancement

Instead of suggesting a check date in the past the app should always pre-filled the Date and Time selector with the current date.

Expected Benefits

Does it make sense to check the validity for some time in the past? So one benefit would be to avoid errors when a certificate is validated, especially as the app gives some strange error about missing rule sets when a past date is used.

And user could more quickly validate their current vaccination status.


Internal Tracking ID: EXPOSUREAPP-14095

Ein-Tim commented 2 years ago

Thanks for reporting this issue!

This was fixed before (version 2.23) but it seems like the change was reverted later.

Here's the issue I opened back when the feature was implemented: https://github.com/corona-warn-app/cwa-app-ios/issues/3839

Ein-Tim commented 2 years ago

@dsarkar

While the picker was changed so that the user can't select dates in the past, the "default" date isn't now but rather the last time the feature was used. Thus a check against a date in the past is still possible.

Here are two screenshots where you can see this problem.

dsarkar commented 2 years ago

@Ein-Tim Many thanks, got it!

dsarkar commented 2 years ago

@skra72 Thanks for reporting, we will create an internal ticket.

30mar commented 1 year ago

will set to obsolete as the effect is only until 31.4.2023