Grooming of DCC Rules Master-Excel

corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:

https://coronawarn.app/en/faq/#ramp_down

Apache License 2.0

3.28k stars 346 forks source link

Grooming of DCC Rules Master-Excel #734

Closed BrittaTSI closed 2 years ago

BrittaTSI commented 3 years ago

Reaction to comments on Master-Excel from RKI.

2Do: Wording

[x] check wording for rules and translations
[x] change incorrect translations to fit German version

Deeplinks

[x] check deeplinks to rule JSONs
[x] add correct deeplink to JSON for TR-DE-0005

Change rules

[x] check possibility in version of CERTLOGIC that is used in apps that are currently in the field to change "+180d" to "+6m" and "+365d" to"+1year"

Result: it is not possible to make these changes as they are not compatible with the CERTLOGIC versions used in older versions of the CWA

CERTLOGIC

[x] check who specified CERTLOGIC engine version as "2.0.1"
[x] check which value is correct and change Excel accordingly

Ein-Tim commented 3 years ago

@BrittaTSI

Could we get a bit context on this issue, please? To which document(s) do you refer?

Thank you & have a nice evening!

BrittaTSI commented 3 years ago

Hi @Ein-Tim, this refers to the (non-public) Excel-Sheet that is used by RKI, BMG, SAP and T-Systems to manage the Acceptance, Validation and Booster Notification rules for Digital Covid Certificates that are used by the CWA, CovPass Check, etc. e.g. to check if your vaccination or test certificate is valid in Germany or in the future also to inform you that you might be eligible for a booster shot. We have made a lot of changes to the rules during the process of defining and updating so we need to do some grooming to eliminate some minor inconsistencies. Unfortunately the issue does not really not fit properly into any of the repositories we are using so I chose "cwa-documentation" because it was the least inappropriate, so to speak. ;-) I hope this answers your question? A nice evening to you, too!

pkern commented 3 years ago

Is the resulting JSON ruleset actually publicly available?

BrittaTSI commented 3 years ago

@pkern - Upon request from RKI/BMG the JSON is also stored in a private repository. Please mind that DCC rule management is not a direct part of the Corona-Warn-App project.

MikeMcC399 commented 3 years ago

@BrittaTSI

I don't believe it makes sense to track issues in this GitHub repository if the objects it concerns are not visible in this repository.

Perhaps you could find somewhere else, non-public, to do your tracking for this?

Ein-Tim commented 2 years ago

@BrittaTSI Hey Britta, did you think about placing this issue in another repository, or maybe the issue you describe in the OP was already fixed? Thanks for the feedback!

BrittaTSI commented 2 years ago

@Ein-Tim - thank you for the comment. This issue is indeed fixed and I will close it here.