corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 346 forks source link

Notification information text regarding booster info contains confusing technical data, and this in inconsistent format #737

Closed jkrwdf closed 2 years ago

jkrwdf commented 3 years ago

Where to find the issue

The notification regarding booster. See screenshot.

image

Describe the issue

  1. Showing the technical rule identifier is confusing for the regular user.
  2. The same rule is printed in two different formats in the same text ("DE-BNR-0110" vs "BNR-DE-0110").

Suggested change

  1. Eventually you can hide the technical details behind a "Technical Information" button/link/excursus/...
  2. Harmonize the format.
MikeMcC399 commented 3 years ago

@jkrwdf You did not say whether the screenshot is from Android or iOS. I'm guessing Android and maybe you could confirm?

There is an equivalent screenshot from iOS on https://www.coronawarn.app/de/blog/2021-11-04-cwa-booster-notification/ which shows only BNR-DE-0110 displayed and only in one place, so it looks like this is a problem on Android only.

The actual screenshot is:

Benachrichtigung-70

and I would guess that it is iOS because the label "Gültigkeit prüfen" is in mixed-case.

jkrwdf commented 3 years ago

Yes, this is on Android.

I always seem to pick the wrong repo ;-) My issues I open for Android are regularly cross-platform, while those which I definitely assume to be cross-platform are platform specific. Argh!

What speaks for the "documentation" repo still: Issue 1, which also appears in iOS as per your screenshot.

MikeMcC399 commented 3 years ago

@jkrwdf

What speaks for the "documentation" repo still: Issue 1, which also appears in iOS as per your screenshot.

I agree. The rule names should be consistent across iOS and Android. There are two issues you have described, so I would wait to see what @dsarkar responds.

Ein-Tim commented 3 years ago

@MikeMcC399

I agree. The rule names should be consistent across iOS and Android.

They are. However, @jkrwdf shared a screenshot where the text says

"Da sie laut Ihrer gespeicherten Zertifikate dieser Personengruppe angehören [...]"

(One rule - you are already in the group)

and the screenshot you shared says:

"Da sie laut Ihrer gespeicherten Zertifikate bald dieser Personengruppe angehören [...]

(Another rule, you will be in the group soon)


I checked on my iPhone XR & on a Huawei P Smart 2019 with the same certificate, the text is:

"Da sie laut Ihrer gespeicherten Zertifikate bald dieser Personengruppe angehören [...]

and the rule is DE-BNR-0100 on both iOS & Android.

Or did I understand you wrong here?

mlenkeit commented 3 years ago

@jkrwdf thanks for opening the ticket! It's an unfortunate typo in the shared rule description. That's also why it occurs on iOS and Android.

MikeMcC399 commented 3 years ago

@mlenkeit Are the booster rules visible anywhere on GitHub?

mlenkeit commented 3 years ago

@MikeMcC399 no, they are not at the moment.

Regarding inconsistencies: as @Ein-Tim mentioned, there is BNR-DE-0100 and BNR-DE-0200 with bald/soon in the text and then there's BNR-DE-0110 and BNR-DE-0210 without bald/soon.

vaubaehn commented 3 years ago

Personally, I find the rule number to be displayed extremely helpful for debugging reasons. Not putting it into the text and having it displayed at the bottom in a less prominent way could be better UX, though.

Jo-Achim commented 3 years ago

Another two points to both screenshots above and in their "Impfstatus" context ("Letzte Impfung vor 170 Tagen" e.g.):

  1. Behind the word "Impfstatus", the screenshots show a 'red point'. In CWA 2.13.2 under Android 11, there is no 'red point'!
  2. I remember in the past (CWA 2.12?) there was a second 'red marker' in the first certificates screen in conjunction with the "Impfstatus" 'red point'. This 'red marker' is missing too (CWA 2.13.2). Looking in CovPass 1.12.0, the little 'red point' is still there (inside the shield-symbol).

PS: I'm not sure if the 'red dot' in the CovPass Certificates-Shield-Symbol is the best idea. (Unsuspecting people could draw wrong conclusions from the 'red dot'.)

jkrwdf commented 3 years ago

Looking again at the message today, the content has changed:

image

The rule number is now presented at both locations with the same ID ("BNR-DE-0110"). But still, the label is different ("Regel" (without colon) vs. "Regel-ID" (with colon)), this double appearance is weird, and still I consider this number as inappropriate in this text body, but see it at the very bottom as a single piece of information, eventually prepended by some "Technical Information" text (which in future may be enriched with further data, maybe the date when the rule data were last updated.

BTW: The fact that although the last vaccination is only 50 days old but this text is still present is an issue which is already addressed in another issue. No need for action here.

Ein-Tim commented 2 years ago

@jkrwdf I just rechecked and IMO the situation has improved here and this issue can be closed:

iOS Android
   
jkrwdf commented 2 years ago

Very well. Thanks. Closing.