corona-warn-app / cwa-documentation

Project overview, general documentation, and white papers. The CWA development ends on May 31, 2023. You still can warn other users until April 30, 2023. More information:
https://coronawarn.app/en/faq/#ramp_down
Apache License 2.0
3.28k stars 344 forks source link

Warning appears when adding the certificates from more than 3 persons to the app #786

Closed Ein-Tim closed 2 years ago

Ein-Tim commented 2 years ago

Avoid duplicates

Technical details

Describe the bug

With version 2.15.1, there is now a person limit for certificates. This means, that only a limited amount of certificates from different persons can be stored in the app. The limit is 20, at the moment. This works as intended.

However, there is also a warning which should be shown always if a user has stored more than 10 persons in their app.

The variable (10) is configured here:

https://github.com/corona-warn-app/cwa-server/blob/4560eb4f1273f2b6e87aea03c0f8ae74dee539d0/services/distribution/src/main/resources/application.yaml#L129

However, in reality, the app always warns if a user has more than 3 certificates stored in the app.

Here are videos from iOS & Android :

https://user-images.githubusercontent.com/67682506/147660470-17c49ecd-06cd-4d0d-9168-18892a2fe02b.mp4

https://user-images.githubusercontent.com/67682506/147660487-9ff07db0-8289-4a0a-830a-fe77e5c462c4.mp4

Steps to reproduce the issue

  1. Remove all stored certificates from the app
  2. Add 3 certificates from different persons to the app
  3. When scanning the 4th certificate from another person, see the warning

Expected behaviour

The warning should only be displayed when more than 10 certificates from different persons are stored on the device.

Ping

@dsarkar We talked about this here: https://github.com/corona-warn-app/cwa-server/pull/1630#discussion_r775663519


Internal Tracking ID: EXPOSUREAPP-11125

MikeMcC399 commented 2 years ago

This feature is so far undocumented (apart from being announced on Twitter). See https://github.com/corona-warn-app/cwa-website/issues/2217.

dsarkar commented 2 years ago

@Ein-Tim @MikeMcC399 Internal Tracking ID: EXPOSUREAPP-11125

MikeMcC399 commented 2 years ago

Running Android Corona-Warn-App-2.15.1-RC3-deviceForTesters-debug.apk with PROD environment shows Remote Config Data:

So, this is either a documentation or a server-side issue. The app looks like it is doing as instructed.

Ein-Tim commented 2 years ago

@MikeMcC399 Yes, I also assume that actually another config is used and the values on GitHub were not updated.

MikeMcC399 commented 2 years ago

@Ein-Tim So the issue is that the branch https://github.com/corona-warn-app/cwa-server/tree/main does not represent the production state of the server which provides the data for https://svc90.main.px.t-online.de/version/v2/app_config_android

and the deployment process from cwa-server to the CDN access point is not documented in https://github.com/corona-warn-app/cwa-server.

The feedback is missing about whether there is an intentional difference in the parameter on GitHub compared to the one served to the app.

dsarkar commented 2 years ago

@Ein-Tim @MikeMcC399

I got feedback: This is intentional and not a bug.

Ein-Tim commented 2 years ago

@dsarkar

Okay, thanks. I will then follow up with an issue in the https://github.com/corona-warn-app/cwa-server repository, addressing this inconsistency.

Closing as answered.

Ein-Tim commented 2 years ago

https://github.com/corona-warn-app/cwa-server/issues/1672 opened to address out-of-sync variable in PROD server vs. GitHub repository.